Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issue 2607113002: Add subresource filter browser tests for failed and history navigations. (Closed)

Created:
3 years, 11 months ago by engedy
Modified:
3 years, 11 months ago
Reviewers:
melandory
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add subresource filter browser tests for failed and history navigations. BUG=637415 Committed: https://crrev.com/a0e4e8abc0143ca977fb2857f4029e5e94a252f7 Cr-Commit-Position: refs/heads/master@{#440961}

Patch Set 1 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -9 lines) Patch
M chrome/browser/subresource_filter/subresource_filter_browsertest.cc View 5 chunks +94 lines, -9 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
engedy
Tanja, moar tests, please take a look.
3 years, 11 months ago (2016-12-29 16:01:40 UTC) #6
melandory
On 2016/12/29 16:01:40, engedy wrote: > Tanja, moar tests, please take a look. lgtm
3 years, 11 months ago (2016-12-29 16:05:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607113002/40001
3 years, 11 months ago (2016-12-29 16:33:30 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:40001)
3 years, 11 months ago (2016-12-29 16:37:41 UTC) #19
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a0e4e8abc0143ca977fb2857f4029e5e94a252f7 Cr-Commit-Position: refs/heads/master@{#440961}
3 years, 11 months ago (2017-01-02 15:52:26 UTC) #21
jwd
3 years, 11 months ago (2017-01-02 15:56:23 UTC) #22
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:40001) has been created in
https://codereview.chromium.org/2609083002/ by jwd@chromium.org.

The reason for reverting is: FailedProvisionalLoadInMainframe appears to be
flaky, and causing many failures the webkit mac bots.
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/...

(first failure:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/...).

Powered by Google App Engine
This is Rietveld 408576698