Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2607103003: Update color/thickness of ChromeOS login shelf button focus state. (Closed)

Created:
3 years, 11 months ago by Evan Stade
Modified:
3 years, 11 months ago
Reviewers:
xiyuan, Greg Levin
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update color/thickness of ChromeOS login shelf button focus state. BUG=615892 Review-Url: https://codereview.chromium.org/2607103003 Cr-Commit-Position: refs/heads/master@{#442747} Committed: https://chromium.googlesource.com/chromium/src/+/75527aec33e8bd011e19318962b9bf5610081a42

Patch Set 1 #

Total comments: 2

Patch Set 2 : oboe #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/login/oobe.css View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Evan Stade
3 years, 11 months ago (2016-12-29 23:31:35 UTC) #2
Greg Levin
https://codereview.chromium.org/2607103003/diff/1/ui/login/oobe.css File ui/login/oobe.css (right): https://codereview.chromium.org/2607103003/diff/1/ui/login/oobe.css#newcode47 ui/login/oobe.css:47: border-color: rgba(66, 133, 244, 0.6); /* #4284f4 */ /* ...
3 years, 11 months ago (2017-01-04 17:52:09 UTC) #4
Evan Stade
ping alemate https://codereview.chromium.org/2607103003/diff/1/ui/login/oobe.css File ui/login/oobe.css (right): https://codereview.chromium.org/2607103003/diff/1/ui/login/oobe.css#newcode47 ui/login/oobe.css:47: border-color: rgba(66, 133, 244, 0.6); /* #4284f4 ...
3 years, 11 months ago (2017-01-04 23:21:01 UTC) #5
Greg Levin
On 2017/01/04 23:21:01, Evan Stade wrote: > ping alemate > > https://codereview.chromium.org/2607103003/diff/1/ui/login/oobe.css > File ui/login/oobe.css ...
3 years, 11 months ago (2017-01-05 16:40:52 UTC) #6
Evan Stade
-alemate, +xiyuan
3 years, 11 months ago (2017-01-09 20:55:39 UTC) #8
xiyuan
lgtm
3 years, 11 months ago (2017-01-09 21:06:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607103003/20001
3 years, 11 months ago (2017-01-11 00:40:28 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 00:57:31 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/75527aec33e8bd011e19318962b9...

Powered by Google App Engine
This is Rietveld 408576698