Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2607073002: Fold the GPU rasterization tests into the pixel tests step. (Closed)

Created:
3 years, 11 months ago by Ken Russell (switch to Gerrit)
Modified:
3 years, 11 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, Kai Ninomiya, ericrk
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fold the GPU rasterization tests into the pixel tests step. This has the side-effect of using the new GPU integration test harness for these tests. BUG=352807, 676701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=zmo@chromium.org Committed: https://crrev.com/abf38db92dc4cfecaa8e58cb4f8925414b8607d5 Cr-Commit-Position: refs/heads/master@{#440947}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -1372 lines) Patch
M content/test/gpu/generate_buildbot_json.py View 1 chunk +0 lines, -7 lines 0 comments Download
D content/test/gpu/gpu_tests/gpu_rasterization.py View 1 chunk +0 lines, -87 lines 0 comments Download
D content/test/gpu/gpu_tests/gpu_rasterization_expectations.py View 1 chunk +0 lines, -17 lines 0 comments Download
D content/test/gpu/gpu_tests/memory_test_expectations.py View 1 chunk +0 lines, -15 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_integration_test.py View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_test_pages.py View 2 chunks +141 lines, -6 lines 0 comments Download
M content/test/gpu/page_sets/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
D content/test/gpu/page_sets/gpu_rasterization_tests.py View 1 chunk +0 lines, -134 lines 0 comments Download
M testing/buildbot/chromium.gpu.json View 8 chunks +0 lines, -186 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 42 chunks +11 lines, -919 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Ken Russell (switch to Gerrit)
FYI. I'll CQ this TBR'd if the tryjobs look good. Tested locally.
3 years, 11 months ago (2016-12-29 06:41:15 UTC) #3
Ken Russell (switch to Gerrit)
On 2016/12/29 06:41:15, Ken Russell OOO-till-Jan-3 wrote: > FYI. I'll CQ this TBR'd if the ...
3 years, 11 months ago (2016-12-29 08:52:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2607073002/1
3 years, 11 months ago (2016-12-29 08:52:36 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 08:57:40 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/abf38db92dc4cfecaa8e58cb4f8925414b8607d5 Cr-Commit-Position: refs/heads/master@{#440947}
3 years, 11 months ago (2017-01-02 15:52:01 UTC) #16
Zhenyao Mo
3 years, 11 months ago (2017-01-03 18:21:16 UTC) #17
Message was sent while issue was closed.
On 2017/01/02 15:52:01, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/abf38db92dc4cfecaa8e58cb4f8925414b8607d5
> Cr-Commit-Position: refs/heads/master@{#440947}

lgtm after the fact

Powered by Google App Engine
This is Rietveld 408576698