[Autofill] Credit Card Autofill Last Used Date Experiment

components/autofill/core/browser/autofill_experiments.cc

Index: components/autofill/core/browser/autofill_experiments.cc
diff --git a/components/autofill/core/browser/autofill_experiments.cc b/components/autofill/core/browser/autofill_experiments.cc
index 92dfff2ec07feb518449375af08dfc7179a5b4cc..8f98580b86aebea2bf38511a22c6033cb2c830f6 100644
--- a/components/autofill/core/browser/autofill_experiments.cc
+++ b/components/autofill/core/browser/autofill_experiments.cc
@@ -32,16 +32,21 @@ const base::Feature kAutofillScanCardholderName{
     "AutofillScanCardholderName", base::FEATURE_DISABLED_BY_DEFAULT};
 const base::Feature kAutofillCreditCardPopupLayout{
     "AutofillCreditCardPopupLayout", base::FEATURE_DISABLED_BY_DEFAULT};
+const base::Feature kAutofillCreditCardLastUsedDateDisplay{
+    "AutofillCreditCardLastUsedDateDisplay", base::FEATURE_DISABLED_BY_DEFAULT};
 const char kCreditCardSigninPromoImpressionLimitParamKey[] = "impression_limit";
 const char kAutofillCreditCardPopupBackgroundColorKey[] = "background_color";
 const char kAutofillCreditCardPopupDividerColorKey[] = "dropdown_divider_color";
 const char kAutofillCreditCardPopupValueBoldKey[] = "is_value_bold";
 const char kAutofillCreditCardPopupIsValueAndLabelInSingleLineKey[] =
     "is_value_and_label_in_single_line";
-const char kAutofillPopupDropdownItemHeightKey[] =
-    "dropdown_item_height";
+const char kAutofillPopupDropdownItemHeightKey[] = "dropdown_item_height";
 const char kAutofillCreditCardPopupIsIconAtStartKey[] =
     "is_credit_card_icon_at_start";
+const char kAutofillCreditCardLastUsedDateShowExpirationDateKey[] =
+    "show_expiration_date";
+const char kAutofillCreditCardLastUsedDateShowTimeDetailKey[] =

[Jared Saul, 2017/01/18 18:43:44]

The previous file (and later in this one) calls the experiments
ShowExpirationDate and ShowDetailedTimeInfo, but this line uses ShowTimeDetail
instead.  Would prefer consistency (ShowDetailedTimeInfoKey?)

[jiahuiguo, 2017/01/18 22:18:12]

Consist to showTimeDetail, otherwise the feature variation name will exceed the
column limit.

+    "show_time_detail";
 
 namespace {
 
@@ -96,6 +101,10 @@ bool IsAutofillCreditCardPopupLayoutExperimentEnabled() {
   return base::FeatureList::IsEnabled(kAutofillCreditCardPopupLayout);
 }
 
+bool IsAutofillCreditCardLastUsedDateDisplayExperimentEnabled() {
+  return base::FeatureList::IsEnabled(kAutofillCreditCardLastUsedDateDisplay);
+}
+
 // |GetCreditCardPopupParameterUintValue| returns 0 if experiment parameter is
 // not specified. 0 == |SK_ColorTRANSPARENT|.
 SkColor GetCreditCardPopupBackgroundColor() {
@@ -125,6 +134,20 @@ bool IsIconInCreditCardPopupAtStart() {
   return param_value == "true";
 }
 
+bool ShowExpirationDateInAutofillCreditCardLastUsedDate() {
+  const std::string param_value = variations::GetVariationParamValueByFeature(
+      kAutofillCreditCardLastUsedDateDisplay,
+      kAutofillCreditCardLastUsedDateShowExpirationDateKey);
+  return param_value == "true";
+}
+
+bool ShowDetailedTimeInfoInAutofillCreditCardLastUsedDate() {
+  const std::string param_value = variations::GetVariationParamValueByFeature(
+      kAutofillCreditCardLastUsedDateDisplay,
+      kAutofillCreditCardLastUsedDateShowTimeDetailKey);
+  return param_value == "true";
+}
+
 // Modifies |suggestion| as follows if experiment to display value and label in
 // a single line is enabled.
 // Say, |value| is 'Visa ....1111' and |label| is '01/18' (expiration date).