[Autofill] Credit Card Autofill Last Used Date Experiment

components/autofill/core/browser/autofill_experiments.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_experiments.h"
 
 #include "base/command_line.h"
 #include "base/feature_list.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/string16.h"
@@ skipping 14 matching lines @@
 namespace autofill {
 
 const base::Feature kAutofillCreditCardAssist{
     "AutofillCreditCardAssist", base::FEATURE_DISABLED_BY_DEFAULT};
 const base::Feature kAutofillCreditCardSigninPromo{
     "AutofillCreditCardSigninPromo", base::FEATURE_DISABLED_BY_DEFAULT};
 const base::Feature kAutofillScanCardholderName{
     "AutofillScanCardholderName", base::FEATURE_DISABLED_BY_DEFAULT};
 const base::Feature kAutofillCreditCardPopupLayout{
     "AutofillCreditCardPopupLayout", base::FEATURE_DISABLED_BY_DEFAULT};
+const base::Feature kAutofillCreditCardLastUsedDateDisplay{
+    "AutofillCreditCardLastUsedDateDisplay", base::FEATURE_DISABLED_BY_DEFAULT};
 const char kCreditCardSigninPromoImpressionLimitParamKey[] = "impression_limit";
 const char kAutofillCreditCardPopupBackgroundColorKey[] = "background_color";
 const char kAutofillCreditCardPopupDividerColorKey[] = "dropdown_divider_color";
 const char kAutofillCreditCardPopupValueBoldKey[] = "is_value_bold";
 const char kAutofillCreditCardPopupIsValueAndLabelInSingleLineKey[] =
     "is_value_and_label_in_single_line";
-const char kAutofillPopupDropdownItemHeightKey[] =
-    "dropdown_item_height";
+const char kAutofillPopupDropdownItemHeightKey[] = "dropdown_item_height";
 const char kAutofillCreditCardPopupIsIconAtStartKey[] =
     "is_credit_card_icon_at_start";
+const char kAutofillCreditCardLastUsedDateShowExpirationDateKey[] =
+    "show_expiration_date";
+const char kAutofillCreditCardLastUsedDateShowTimeDetailKey[] =

[Jared Saul, 2017/01/18 18:43:44]

The previous file (and later in this one) calls the experiments
ShowExpirationDate and ShowDetailedTimeInfo, but this line uses ShowTimeDetail
instead.  Would prefer consistency (ShowDetailedTimeInfoKey?)

[jiahuiguo, 2017/01/18 22:18:12]

Consist to showTimeDetail, otherwise the feature variation name will exceed the
column limit.

+    "show_time_detail";
 
 namespace {
 
 // Returns parameter value in |kAutofillCreditCardPopupLayout| feature, or 0 if
 // parameter is not specified.
 unsigned int GetCreditCardPopupParameterUintValue(
     const std::string& param_name) {
   unsigned int value;
   const std::string param_value = variations::GetVariationParamValueByFeature(
       kAutofillCreditCardPopupLayout, param_name);
@@ skipping 34 matching lines @@
   if (!param_value.empty() && base::StringToInt(param_value, &impression_limit))
     return impression_limit;
 
   return 0;
 }
 
 bool IsAutofillCreditCardPopupLayoutExperimentEnabled() {
   return base::FeatureList::IsEnabled(kAutofillCreditCardPopupLayout);
 }
 
+bool IsAutofillCreditCardLastUsedDateDisplayExperimentEnabled() {
+  return base::FeatureList::IsEnabled(kAutofillCreditCardLastUsedDateDisplay);
+}
+
 // |GetCreditCardPopupParameterUintValue| returns 0 if experiment parameter is
 // not specified. 0 == |SK_ColorTRANSPARENT|.
 SkColor GetCreditCardPopupBackgroundColor() {
   return GetCreditCardPopupParameterUintValue(
       kAutofillCreditCardPopupBackgroundColorKey);
 }
 
 SkColor GetCreditCardPopupDividerColor() {
   return GetCreditCardPopupParameterUintValue(
       kAutofillCreditCardPopupDividerColorKey);
 }
 
 bool IsCreditCardPopupValueBold() {
   const std::string param_value = variations::GetVariationParamValueByFeature(
       kAutofillCreditCardPopupLayout, kAutofillCreditCardPopupValueBoldKey);
   return param_value == "true";
 }
 
 unsigned int GetPopupDropdownItemHeight() {
   return GetCreditCardPopupParameterUintValue(
       kAutofillPopupDropdownItemHeightKey);
 }
 
 bool IsIconInCreditCardPopupAtStart() {
   const std::string param_value = variations::GetVariationParamValueByFeature(
       kAutofillCreditCardPopupLayout, kAutofillCreditCardPopupIsIconAtStartKey);
   return param_value == "true";
 }
 
+bool ShowExpirationDateInAutofillCreditCardLastUsedDate() {
+  const std::string param_value = variations::GetVariationParamValueByFeature(
+      kAutofillCreditCardLastUsedDateDisplay,
+      kAutofillCreditCardLastUsedDateShowExpirationDateKey);
+  return param_value == "true";
+}
+
+bool ShowDetailedTimeInfoInAutofillCreditCardLastUsedDate() {
+  const std::string param_value = variations::GetVariationParamValueByFeature(
+      kAutofillCreditCardLastUsedDateDisplay,
+      kAutofillCreditCardLastUsedDateShowTimeDetailKey);
+  return param_value == "true";
+}
+
 // Modifies |suggestion| as follows if experiment to display value and label in
 // a single line is enabled.
 // Say, |value| is 'Visa ....1111' and |label| is '01/18' (expiration date).
 // Modifies |value| to 'Visa ....1111, exp 01/18' and clears |label|.
 void ModifyAutofillCreditCardSuggestion(Suggestion* suggestion) {
   DCHECK(IsAutofillCreditCardPopupLayoutExperimentEnabled());
   const std::string param_value = variations::GetVariationParamValueByFeature(
       kAutofillCreditCardPopupLayout,
       kAutofillCreditCardPopupIsValueAndLabelInSingleLineKey);
   if (param_value == "true") {
@@ skipping 77 matching lines @@
   }
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kDisableOfferUploadCreditCards)) {
     return false;
   }
 
   return !group_name.empty() && group_name != "Disabled";
 }
 
 }  // namespace autofill