Flush after ResourcePool deletions complete

Flush after ResourcePool deletions complete

Currently, ResourcePool queues up idle resource deletion 1 second
after last use. This means that the resource may be deleted after
the main context becomes completely idle, and no further frames
are bein produced. In order to ensure that these deletions are
propogated to the GPU process, this change introduces a shallow
flush after the last freeable resource is deleted by the
ResourcePool.

BUG=671256
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2607033002
Cr-Commit-Position: refs/heads/master@{#442937}
Committed: https://chromium.googlesource.com/chromium/src/+/8e825d9a15aa6b2d16637fd59d2c0072c60d60ea

[ericrk, 2016-12-28 23:54:16]

Description was changed from

==========
Flush after ResourcePool deletions complete

Currently, ResourcePool queues up idle resource deletion 1 second
after last use. This means that the resource may be deleted after
the main context becomes completely idle, and no further frames
are bein produced. In order to ensure that theese deletions are
propogated to the GPU process, this change introduces a shallow
flush after the last freeable resource is deleted by the
ResourcePool.

BUG=671256
==========

to

==========
Flush after ResourcePool deletions complete

Currently, ResourcePool queues up idle resource deletion 1 second
after last use. This means that the resource may be deleted after
the main context becomes completely idle, and no further frames
are bein produced. In order to ensure that theese deletions are
propogated to the GPU process, this change introduces a shallow
flush after the last freeable resource is deleted by the
ResourcePool.

BUG=671256
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ericrk, 2016-12-28 23:55:21]

ericrk@chromium.org changed reviewers:
+ vmpstr@chromium.org

[ericrk, 2017-01-09 21:36:15]

friendly ping :D

[vmpstr, 2017-01-09 21:43:43]

lgtm

nit: s/theese/these/ in the description.

https://codereview.chromium.org/2607033002/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/2607033002/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl.cc:1474: if (!visible_) {
nit: no braces

[ericrk, 2017-01-09 23:25:39]

Description was changed from

==========
Flush after ResourcePool deletions complete

Currently, ResourcePool queues up idle resource deletion 1 second
after last use. This means that the resource may be deleted after
the main context becomes completely idle, and no further frames
are bein produced. In order to ensure that theese deletions are
propogated to the GPU process, this change introduces a shallow
flush after the last freeable resource is deleted by the
ResourcePool.

BUG=671256
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Flush after ResourcePool deletions complete

Currently, ResourcePool queues up idle resource deletion 1 second
after last use. This means that the resource may be deleted after
the main context becomes completely idle, and no further frames
are bein produced. In order to ensure that these deletions are
propogated to the GPU process, this change introduces a shallow
flush after the last freeable resource is deleted by the
ResourcePool.

BUG=671256
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ericrk, 2017-01-09 23:29:20]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2017-01-09 23:29:20]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2607033002/#ps40001
(title: "remove brace")

[commit-bot: I haz the power, 2017-01-09 23:30:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 00:39:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 00:39:10]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[ericrk, 2017-01-10 19:19:26]

The CQ bit was checked by ericrk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 19:19:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ericrk, 2017-01-10 19:27:30]

The CQ bit was unchecked by ericrk@chromium.org

[ericrk, 2017-01-10 19:27:30]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2017-01-10 19:27:31]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2607033002/#ps60001
(title: "fix |resource_provider_| check")

[commit-bot: I haz the power, 2017-01-10 19:27:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 21:01:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 21:01:13]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[ericrk, 2017-01-11 01:25:21]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2017-01-11 01:25:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 03:26:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 03:26:46]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[ericrk, 2017-01-11 16:37:44]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2017-01-11 16:38:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 17:13:01]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484152664421710,
"parent_rev": "5e2c34d46083dc28796e3e68e34b2b8231a8c5cc", "commit_rev":
"8e825d9a15aa6b2d16637fd59d2c0072c60d60ea"}

[commit-bot: I haz the power, 2017-01-11 17:13:30]

Description was changed from

==========
Flush after ResourcePool deletions complete

Currently, ResourcePool queues up idle resource deletion 1 second
after last use. This means that the resource may be deleted after
the main context becomes completely idle, and no further frames
are bein produced. In order to ensure that these deletions are
propogated to the GPU process, this change introduces a shallow
flush after the last freeable resource is deleted by the
ResourcePool.

BUG=671256
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Flush after ResourcePool deletions complete

Currently, ResourcePool queues up idle resource deletion 1 second
after last use. This means that the resource may be deleted after
the main context becomes completely idle, and no further frames
are bein produced. In order to ensure that these deletions are
propogated to the GPU process, this change introduces a shallow
flush after the last freeable resource is deleted by the
ResourcePool.

BUG=671256
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2607033002
Cr-Commit-Position: refs/heads/master@{#442937}
Committed:
https://chromium.googlesource.com/chromium/src/+/8e825d9a15aa6b2d16637fd59d2c...
==========

[commit-bot: I haz the power, 2017-01-11 17:13:31]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8e825d9a15aa6b2d16637fd59d2c...