Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2607003002:
Set needs paint property update for changes of SVG isolation and blending. (Closed)
|
Created:
3 years, 11 months ago by chrishtr Modified:
3 years, 11 months ago Reviewers:
Xianzhu CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1 Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSet needs paint property update for changes of SVG isolation and blending.
BUG=677241
TEST=css3/blending/svg-isolation-*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Committed: https://crrev.com/f622c97dff9a1df040b5faf60a0948ce9c4df0e1
Cr-Commit-Position: refs/heads/master@{#440913}
Patch Set 1 #Patch Set 2 : none #
Total comments: 1
Patch Set 3 : none #
Total comments: 2
Patch Set 4 : none #
Total comments: 4
Patch Set 5 : none #
Messages
Total messages: 26 (16 generated)
Description was changed from ========== none none Merge branch 'master' into fixunderpaint none none none none BUG= ========== to ========== none none Merge branch 'master' into fixunderpaint none none none none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
Description was changed from ========== none none Merge branch 'master' into fixunderpaint none none none none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Set needs paint property update for changes of SVG isolation and blending. BUG=677241 TEST=css3/blending/svg-isolation-add-masking.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
Description was changed from ========== Set needs paint property update for changes of SVG isolation and blending. BUG=677241 TEST=css3/blending/svg-isolation-add-masking.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Set needs paint property update for changes of SVG isolation and blending. BUG=677241 TEST=css3/blending/svg-isolation-* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
chrishtr@chromium.org changed reviewers: + wangxianzhu@chromium.org
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2607003002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 (right): https://codereview.chromium.org/2607003002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2:141: Bug(none) compositing/geometry/layer-due-to-layer-children-deep.html [ Failure ] Removed this - it was on the wrong patch.
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2607003002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp (right): https://codereview.chromium.org/2607003002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp:126: SVGLayoutSupport::willIsolateBlendingDescendantsForObject(this) Can you by the way refactor to avoid duplicated call to willIsolateBlendingDescendantsForObject?
https://codereview.chromium.org/2607003002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp (right): https://codereview.chromium.org/2607003002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp:126: SVGLayoutSupport::willIsolateBlendingDescendantsForObject(this) On 2016/12/28 at 23:14:37, Xianzhu wrote: > Can you by the way refactor to avoid duplicated call to willIsolateBlendingDescendantsForObject? Done.
The CQ bit was checked by chrishtr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wangxianzhu@chromium.org Link to the patchset: https://codereview.chromium.org/2607003002/#ps60001 (title: "none")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by wangxianzhu@chromium.org
https://codereview.chromium.org/2607003002/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp (right): https://codereview.chromium.org/2607003002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp:115: bool willIsolateBlendingDescendantsForObject = Nit: s/willIsolateBlendingDescendantsForObject/willIsolateBlendingDescnedants/ https://codereview.chromium.org/2607003002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp:119: hadIsolation == !willIsolateBlendingDescendantsForObject; Nit: s/== !/!=/
https://codereview.chromium.org/2607003002/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp (right): https://codereview.chromium.org/2607003002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp:115: bool willIsolateBlendingDescendantsForObject = On 2016/12/28 at 23:22:58, Xianzhu wrote: > Nit: s/willIsolateBlendingDescendantsForObject/willIsolateBlendingDescnedants/ Done. https://codereview.chromium.org/2607003002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp:119: hadIsolation == !willIsolateBlendingDescendantsForObject; On 2016/12/28 at 23:22:58, Xianzhu wrote: > Nit: s/== !/!=/ Done.
The CQ bit was checked by chrishtr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wangxianzhu@chromium.org Link to the patchset: https://codereview.chromium.org/2607003002/#ps80001 (title: "none")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1482967834364710,
"parent_rev": "0e9c3822da16004f0a73ed03ab52d47e79645b0f", "commit_rev":
"07fe56272803b1bb90b393008bdadc936793f365"}
Message was sent while issue was closed.
Description was changed from ========== Set needs paint property update for changes of SVG isolation and blending. BUG=677241 TEST=css3/blending/svg-isolation-* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Set needs paint property update for changes of SVG isolation and blending. BUG=677241 TEST=css3/blending/svg-isolation-* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2607003002 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Set needs paint property update for changes of SVG isolation and blending. BUG=677241 TEST=css3/blending/svg-isolation-* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2607003002 ========== to ========== Set needs paint property update for changes of SVG isolation and blending. BUG=677241 TEST=css3/blending/svg-isolation-* CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/f622c97dff9a1df040b5faf60a0948ce9c4df0e1 Cr-Commit-Position: refs/heads/master@{#440913} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/f622c97dff9a1df040b5faf60a0948ce9c4df0e1 Cr-Commit-Position: refs/heads/master@{#440913} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
