Media Capture Depth Stream Extensions API: focal length and depth range.

third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp

Index: third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
diff --git a/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp b/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
index 1202c132a53f2578a24ec5e73f45811f16f88745..cd100d9f332df3cbf05eecafbc2f09a2876821ad 100644
--- a/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
+++ b/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
@@ -228,6 +228,12 @@ void MediaStreamTrack::getSettings(MediaTrackSettings& settings) {
   if (platformSettings.hasHeight()) {
     settings.setHeight(platformSettings.height);
   }
+  if (RuntimeEnabledFeatures::mediaCaptureDepthEnabled()) {

[mcasas, 2017/01/11 23:18:20]

I guess this also only makes sense if:
  m_component->source()->type() == MediaStreamSource::TypeVideo

Which is a similar problem to what we see in [1], (check out 
WebMediaStreamTrack.h).  

I believe that the current implementation is not fully up to Spec, 
which is regrettable. The Spec instructs the use of the Constrainable 
Pattern for these occasions: i.e. using the CP we should not return 
any near/far/... in the MediaTrackSupportedConstraints dictionary 
if the said constraints are not supported, and any associated 
MediaTrackCapabilities readings would not have any said
near/far/... in that case, etc.

As things stand right now, I'm afraid the next logical step for you 
would diverge from [2] ... but that'll be for another CL.

[1] https://codereview.chromium.org/2609863004/
[2] https://www.w3.org/TR/mediacapture-depth/#mediatracksettings-dictionary

[aleksandar.stojiljkovic, 2017/01/12 14:13:59]

MediaTrackSupportedConstraints / I understand you meant
MediaStreamConstraints.video [1].
Yes, that's right. Haven't added them to WebMediaConstraints.h [2] either.

[1]
https://w3c.github.io/mediacapture-main/archives/20160513/getusermedia.html#n...
[2]
https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebMe...
I could add them here or defer all IDL changes to the final intrgration patch
but I assume it is better like this to add full API pieces while it is under
flag.
Added TODO for now:
    // TODO(aleksandar.stojiljkovic): Add MediaTrackConstraintSet support for
    // https://www.w3.org/TR/mediacapture-depth/#mediatracksettings-dictionary
    // See also https://crbug.com/616098 and WebMediaConstraints.h.
Thanks.

[aleksandar.stojiljkovic, 2017/01/29 18:45:33]

Done.
PS#6:
- added near, far and focal length to MediaTrackSupportedConstraints and
MediaTrackConstraintSet.
- GetBothStreamsAndCheckForFeaturesPresence test that video and depth stream
tracks contain only relevant constraints and settings. 

+    settings.setDepthNear(platformSettings.depthNear);
+    settings.setDepthFar(platformSettings.depthFar);
+    settings.setFocalLengthX(platformSettings.focalLengthX);
+    settings.setFocalLengthY(platformSettings.focalLengthY);
+  }
   settings.setDeviceId(platformSettings.deviceId);
 }