Media Capture Depth Stream Extensions API: focal length and depth range.

third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  * Copyright (C) 2011 Ericsson AB. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 210 matching lines @@
   m_component->getSettings(platformSettings);
   if (platformSettings.hasFrameRate()) {
     settings.setFrameRate(platformSettings.frameRate);
   }
   if (platformSettings.hasWidth()) {
     settings.setWidth(platformSettings.width);
   }
   if (platformSettings.hasHeight()) {
     settings.setHeight(platformSettings.height);
   }
+  if (RuntimeEnabledFeatures::mediaCaptureDepthEnabled()) {

[mcasas, 2017/01/11 23:18:20]

I guess this also only makes sense if:
  m_component->source()->type() == MediaStreamSource::TypeVideo

Which is a similar problem to what we see in [1], (check out 
WebMediaStreamTrack.h).  

I believe that the current implementation is not fully up to Spec, 
which is regrettable. The Spec instructs the use of the Constrainable 
Pattern for these occasions: i.e. using the CP we should not return 
any near/far/... in the MediaTrackSupportedConstraints dictionary 
if the said constraints are not supported, and any associated 
MediaTrackCapabilities readings would not have any said
near/far/... in that case, etc.

As things stand right now, I'm afraid the next logical step for you 
would diverge from [2] ... but that'll be for another CL.

[1] https://codereview.chromium.org/2609863004/
[2] https://www.w3.org/TR/mediacapture-depth/#mediatracksettings-dictionary

[aleksandar.stojiljkovic, 2017/01/12 14:13:59]

MediaTrackSupportedConstraints / I understand you meant
MediaStreamConstraints.video [1].
Yes, that's right. Haven't added them to WebMediaConstraints.h [2] either.

[1]
https://w3c.github.io/mediacapture-main/archives/20160513/getusermedia.html#n...
[2]
https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebMe...
I could add them here or defer all IDL changes to the final intrgration patch
but I assume it is better like this to add full API pieces while it is under
flag.
Added TODO for now:
    // TODO(aleksandar.stojiljkovic): Add MediaTrackConstraintSet support for
    // https://www.w3.org/TR/mediacapture-depth/#mediatracksettings-dictionary
    // See also https://crbug.com/616098 and WebMediaConstraints.h.
Thanks.

[aleksandar.stojiljkovic, 2017/01/29 18:45:33]

Done.
PS#6:
- added near, far and focal length to MediaTrackSupportedConstraints and
MediaTrackConstraintSet.
- GetBothStreamsAndCheckForFeaturesPresence test that video and depth stream
tracks contain only relevant constraints and settings. 

+    settings.setDepthNear(platformSettings.depthNear);
+    settings.setDepthFar(platformSettings.depthFar);
+    settings.setFocalLengthX(platformSettings.focalLengthX);
+    settings.setFocalLengthY(platformSettings.focalLengthY);
+  }
   settings.setDeviceId(platformSettings.deviceId);
 }
 
 bool MediaStreamTrack::ended() const {
   return m_stopped || (m_readyState == MediaStreamSource::ReadyStateEnded);
 }
 
 void MediaStreamTrack::sourceChangedState() {
   if (ended())
     return;
@@ skipping 73 matching lines @@
 }
 
 DEFINE_TRACE(MediaStreamTrack) {
   visitor->trace(m_registeredMediaStreams);
   visitor->trace(m_component);
   EventTargetWithInlineData::trace(visitor);
   ContextLifecycleObserver::trace(visitor);
 }
 
 }  // namespace blink