Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1492)

Issue 2606933003: Remove nearby URL cache from the PW UrlManager (Closed)

Created:
3 years, 11 months ago by cco3
Modified:
3 years, 11 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org, vitaliii
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove nearby URL cache from the PW UrlManager Given that we can't inspect the status of our Nearby subscription, we have to resubscribe on every startup. That means that there is no point in caching nearby URLs when we will have to repopulate those through the new subscription anyway. Additionally, our current practice is sending noise to listeners (onFound at startup, onLost at cache deletion, onFound at resubscription). This change just removes that cache. BUG=667754 Review-Url: https://codereview.chromium.org/2606933003 Cr-Commit-Position: refs/heads/master@{#442108} Committed: https://chromium.googlesource.com/chromium/src/+/91f5b8d2f34faf9c21fb4c08146cb1a7d9ad2144

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove unnecessary logging #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -28 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java View 1 chunk +1 line, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java View 1 2 8 chunks +3 lines, -13 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java View 1 2 4 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
cco3
3 years, 11 months ago (2016-12-29 00:40:47 UTC) #2
mattreynolds
lgtm https://codereview.chromium.org/2606933003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java (right): https://codereview.chromium.org/2606933003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java#newcode41 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java:41: Log.d(TAG, "cco3 onFound: " + url); remove debug ...
3 years, 11 months ago (2017-01-04 01:25:22 UTC) #3
cco3
Hi Miguel, would you be able to review this change?
3 years, 11 months ago (2017-01-05 22:49:24 UTC) #5
cco3
Hi David, would you be able to review this change?
3 years, 11 months ago (2017-01-06 18:39:35 UTC) #7
David Trainor- moved to gerrit
owners lgtm. thanks!
3 years, 11 months ago (2017-01-06 23:32:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606933003/20001
3 years, 11 months ago (2017-01-06 23:37:07 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/131746) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-06 23:38:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606933003/40001
3 years, 11 months ago (2017-01-06 23:51:42 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-07 00:24:45 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/91f5b8d2f34faf9c21fb4c08146c...

Powered by Google App Engine
This is Rietveld 408576698