Fix crash in AncestorThrottle that was causing a crash in telemetry perf unittests.

Fix crash in AncestorThrottle that was causing a crash in telemetry perf unittests.

The test below started failing after 440055. There was a null dereference in AncestorThrottle for resources that didn't render (i.e. 204s) and so there was no RenderFrameHost being created.

This fixes
telemetry_perf_unittests's benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:media:9gag
with PlzNavigate.

BUG=674730
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/6d3cce3b1fbf2b1ea96e8cadab8a71a4875b1357
Cr-Commit-Position: refs/heads/master@{#441156}

[jam, 2016-12-28 17:57:03]

Description was changed from

==========
Fix crash in AncestorThrottle that was causing a crash in telemetry perf
unittests.

The test below started failing after 440055. There was a null dereference in
AncestorThrottle for resources that didn't render (i.e. 204s) and so there was
no RenderFrameHost being created.

This fixes
telemetry_perf_unittests's
benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:media:9gag
with PlzNavigate.

BUG=674730
==========

to

==========
Fix crash in AncestorThrottle that was causing a crash in telemetry perf
unittests.

The test below started failing after 440055. There was a null dereference in
AncestorThrottle for resources that didn't render (i.e. 204s) and so there was
no RenderFrameHost being created.

This fixes
telemetry_perf_unittests's
benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:media:9gag
with PlzNavigate.

BUG=674730
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2016-12-28 17:58:03]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 17:58:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-12-28 17:59:02]

Description was changed from

==========
Fix crash in AncestorThrottle that was causing a crash in telemetry perf
unittests.

The test below started failing after 440055. There was a null dereference in
AncestorThrottle for resources that didn't render (i.e. 204s) and so there was
no RenderFrameHost being created.

This fixes
telemetry_perf_unittests's
benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:media:9gag
with PlzNavigate.

BUG=674730
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix crash in AncestorThrottle that was causing a crash in telemetry perf
unittests.

The test below started failing after 440055. There was a null dereference in
AncestorThrottle for resources that didn't render (i.e. 204s) and so there was
no RenderFrameHost being created.

This fixes
telemetry_perf_unittests's
benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:media:9gag
with PlzNavigate.

BUG=674730
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2016-12-28 17:59:02]

jam@chromium.org changed reviewers:
+ arthursonzogni@chromium.org

[commit-bot: I haz the power, 2016-12-28 19:22:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 19:22:38]

Dry run: This issue passed the CQ dry run.

[arthursonzogni, 2017-01-02 08:49:08]

Thanks! I think it should be done also in the sibling function:
AncestorThrottle::ParseError.
LGTM once it's done.

[jam, 2017-01-03 16:33:32]

The CQ bit was checked by jam@chromium.org

[jam, 2017-01-03 16:33:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
arthursonzogni@chromium.org
Link to the patchset: https://codereview.chromium.org/2606933002/#ps20001
(title: "review comment")

[commit-bot: I haz the power, 2017-01-03 16:33:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 18:13:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483461212599890,
"parent_rev": "7b0919b1019ab3613c7cf59e0b4b494a7c9d6f05", "commit_rev":
"b7dc44bb104e83d8578b160f03e1225f342db104"}

[commit-bot: I haz the power, 2017-01-03 18:13:27]

Description was changed from

==========
Fix crash in AncestorThrottle that was causing a crash in telemetry perf
unittests.

The test below started failing after 440055. There was a null dereference in
AncestorThrottle for resources that didn't render (i.e. 204s) and so there was
no RenderFrameHost being created.

This fixes
telemetry_perf_unittests's
benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:media:9gag
with PlzNavigate.

BUG=674730
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix crash in AncestorThrottle that was causing a crash in telemetry perf
unittests.

The test below started failing after 440055. There was a null dereference in
AncestorThrottle for resources that didn't render (i.e. 204s) and so there was
no RenderFrameHost being created.

This fixes
telemetry_perf_unittests's
benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:media:9gag
with PlzNavigate.

BUG=674730
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2606933002
==========

[commit-bot: I haz the power, 2017-01-03 18:13:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-03 18:15:22]

Description was changed from

==========
Fix crash in AncestorThrottle that was causing a crash in telemetry perf
unittests.

The test below started failing after 440055. There was a null dereference in
AncestorThrottle for resources that didn't render (i.e. 204s) and so there was
no RenderFrameHost being created.

This fixes
telemetry_perf_unittests's
benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:media:9gag
with PlzNavigate.

BUG=674730
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2606933002
==========

to

==========
Fix crash in AncestorThrottle that was causing a crash in telemetry perf
unittests.

The test below started failing after 440055. There was a null dereference in
AncestorThrottle for resources that didn't render (i.e. 204s) and so there was
no RenderFrameHost being created.

This fixes
telemetry_perf_unittests's
benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.load:media:9gag
with PlzNavigate.

BUG=674730
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/6d3cce3b1fbf2b1ea96e8cadab8a71a4875b1357
Cr-Commit-Position: refs/heads/master@{#441156}
==========

[commit-bot: I haz the power, 2017-01-03 18:15:23]

Patchset 2 (id:??) landed as
https://crrev.com/6d3cce3b1fbf2b1ea96e8cadab8a71a4875b1357
Cr-Commit-Position: refs/heads/master@{#441156}