Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2606923002: [csa] Improve propagation of deferred block mark (Closed)

Created:
3 years, 11 months ago by danno
Modified:
3 years, 11 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[csa] Improve propagation of deferred block mark Before this patch, loops in deferred code would defeat the propagation of the deferred flag, since back edges would usually not come from deferred blocks, thus stoping the forward propagation of the deferred flag at loop headers. This patch ensures that back edges are ignored in the deferred propations, properly placing loops dominated by deferred labels and the code that follows them into deferred code. R=epertoso@chromium.org LOG=N Review-Url: https://codereview.chromium.org/2606923002 Cr-Commit-Position: refs/heads/master@{#41976} Committed: https://chromium.googlesource.com/v8/v8/+/81df56ae5f65d3dac37a8c1fd76a90b77c3504d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/compiler/raw-machine-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/schedule.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
danno
ptal
3 years, 11 months ago (2016-12-28 16:21:04 UTC) #3
epertoso
lgtm
3 years, 11 months ago (2016-12-28 16:28:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606923002/1
3 years, 11 months ago (2016-12-28 16:45:59 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2016-12-28 16:47:45 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/81df56ae5f65d3dac37a8c1fd76a90b77c3...

Powered by Google App Engine
This is Rietveld 408576698