Remove BoxBorderPainter::drawBleedAdjustedDRRect() assert

Remove BoxBorderPainter::drawBleedAdjustedDRRect() assert

While we only ever use BackgroundBleedClipLayer when hasBorderRadius()
is true, certain degenerate radius values can cause the computed radii
to be zero.

In that case the assert no longer holds.  The simplest thing to do is
drop the assert: SkPath::addRRect() checks for the simple rect case and
behaves optimally anyway.

BUG=615814
R=chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/f55c47a99fd4f05e07f5ecc1bd29c359082f43d8
Cr-Commit-Position: refs/heads/master@{#440981}

[f(malita), 2016-12-28 16:12:58]

Description was changed from

==========
Remove BoxBorderPainter::drawBleedAdjustedDRRect() assert

While we only ever use BackgroundBleedClipLayer when hasBorderRadius()
is true, certain degenerate radius values can cause the computed radii
to be zero.

In that case the assert no longer holds.  The simplest thing to do is
drop the assert: SkPath::addRRect() checks for the simple rect case and
behaves optimally anyway.

BUG=615814
R=chrishtr@chromium.org
==========

to

==========
Remove BoxBorderPainter::drawBleedAdjustedDRRect() assert

While we only ever use BackgroundBleedClipLayer when hasBorderRadius()
is true, certain degenerate radius values can cause the computed radii
to be zero.

In that case the assert no longer holds.  The simplest thing to do is
drop the assert: SkPath::addRRect() checks for the simple rect case and
behaves optimally anyway.

BUG=615814
R=chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[f(malita), 2016-12-28 16:14:05]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 16:14:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-12-28 16:14:48]

add the accompanying test?

[commit-bot: I haz the power, 2016-12-28 17:45:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 17:45:47]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-12-29 13:26:44]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 13:26:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-12-29 13:27:11]

On 2016/12/28 16:14:48, chrishtr wrote:
> add the accompanying test?

done

[commit-bot: I haz the power, 2016-12-29 14:40:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 14:40:23]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2016-12-29 16:48:00]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-12-29 16:48:00]

lgtm

[chrishtr, 2016-12-29 16:48:12]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2016-12-29 16:49:04]

https://codereview.chromium.org/2606913002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/borders/degenerate-radius-assert.html
(right):

https://codereview.chromium.org/2606913002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/borders/degenerate-radius-assert.html:6:
background-image: url("data:image/svg+xml,");
Put this test in paint/roundedrects/ instead, we're gradually migrating
paint tests there.

[f(malita), 2016-12-29 18:51:57]

https://codereview.chromium.org/2606913002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/borders/degenerate-radius-assert.html
(right):

https://codereview.chromium.org/2606913002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/borders/degenerate-radius-assert.html:6:
background-image: url("data:image/svg+xml,");
On 2016/12/29 16:49:04, chrishtr wrote:
> Put this test in paint/roundedrects/ instead, we're gradually migrating
> paint tests there.

Done.

[f(malita), 2016-12-29 18:52:03]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-12-29 18:52:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2606913002/#ps40001
(title: "relocate test")

[commit-bot: I haz the power, 2016-12-29 18:52:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 20:17:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483037523403180,
"parent_rev": "00e07e3c53f98b9e76e924ffa0faa68d670f8595", "commit_rev":
"58b82ddcad84a48a4b19660ad5729ea115d962fd"}

[commit-bot: I haz the power, 2016-12-29 20:18:07]

Description was changed from

==========
Remove BoxBorderPainter::drawBleedAdjustedDRRect() assert

While we only ever use BackgroundBleedClipLayer when hasBorderRadius()
is true, certain degenerate radius values can cause the computed radii
to be zero.

In that case the assert no longer holds.  The simplest thing to do is
drop the assert: SkPath::addRRect() checks for the simple rect case and
behaves optimally anyway.

BUG=615814
R=chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove BoxBorderPainter::drawBleedAdjustedDRRect() assert

While we only ever use BackgroundBleedClipLayer when hasBorderRadius()
is true, certain degenerate radius values can cause the computed radii
to be zero.

In that case the assert no longer holds.  The simplest thing to do is
drop the assert: SkPath::addRRect() checks for the simple rect case and
behaves optimally anyway.

BUG=615814
R=chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2606913002
==========

[commit-bot: I haz the power, 2016-12-29 20:18:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2017-01-02 15:53:00]

Description was changed from

==========
Remove BoxBorderPainter::drawBleedAdjustedDRRect() assert

While we only ever use BackgroundBleedClipLayer when hasBorderRadius()
is true, certain degenerate radius values can cause the computed radii
to be zero.

In that case the assert no longer holds.  The simplest thing to do is
drop the assert: SkPath::addRRect() checks for the simple rect case and
behaves optimally anyway.

BUG=615814
R=chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2606913002
==========

to

==========
Remove BoxBorderPainter::drawBleedAdjustedDRRect() assert

While we only ever use BackgroundBleedClipLayer when hasBorderRadius()
is true, certain degenerate radius values can cause the computed radii
to be zero.

In that case the assert no longer holds.  The simplest thing to do is
drop the assert: SkPath::addRRect() checks for the simple rect case and
behaves optimally anyway.

BUG=615814
R=chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/f55c47a99fd4f05e07f5ecc1bd29c359082f43d8
Cr-Commit-Position: refs/heads/master@{#440981}
==========

[commit-bot: I haz the power, 2017-01-02 15:53:01]

Patchset 3 (id:??) landed as
https://crrev.com/f55c47a99fd4f05e07f5ecc1bd29c359082f43d8
Cr-Commit-Position: refs/heads/master@{#440981}