Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2606903002: Import Objective C Frameworks in ui/ (Closed)

Created:
3 years, 11 months ago by Olivier
Modified:
3 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, mac-reviews_chromium.org, rsesek+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Import Objective C Frameworks in ui/ The Objective-C frameworks must be imported and not included. List of Objective-C Frameworks that have been checked: AVFoundation AVKit Accounts AdSupport AddressBookUI AssetsLibrary CallKit CloudKit Contacts ContactsUI CoreAudioKit CoreBluetooth CoreData CoreImage CoreLocation CoreMIDI CoreMotion CoreSpotlight EventKit EventKitUI ExternalAccessory Foundation GLKit GameController GameKit GameplayKit HealthKit HealthKitUI HomeKit Intents IntentsUI JavaScriptCore LocalAuthentication MapKit MediaPlayer MessageUI Messages Metal MetalKit MetalPerformanceShaders ModelIO MultipeerConnectivity NetworkExtension NewsstandKit NotificationCenter PassKit Photos PhotosUI PushKit QuickLook ReplayKit SafariServices SceneKit Social Speech SpriteKit StoreKit Twitter UIKit UserNotifications UserNotificationsUI VideoSubscriberAccount WatchConnectivity WatchKit WebKit iAd BUG=677965 Committed: https://crrev.com/5e148fb50902743d8b41a5b29a7b639e5d2042df Cr-Commit-Position: refs/heads/master@{#441138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/accelerated_widget_mac/ca_layer_tree_unittest_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/accelerated_widget_mac/ca_renderer_layer_tree.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/accelerators/platform_accelerator_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_skia_util_ios.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_util_ios.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Olivier
3 years, 11 months ago (2016-12-28 14:08:21 UTC) #2
Nico
Does this have any effect in practice? As far as I can tell, clang does ...
3 years, 11 months ago (2017-01-03 15:09:59 UTC) #3
Olivier
On 2017/01/03 15:09:59, Nico (ooo sick) wrote: > Does this have any effect in practice? ...
3 years, 11 months ago (2017-01-03 15:20:08 UTC) #4
Nico
lgtm, "style guide says so" is a good reason :-) I'm not sure it's feasible ...
3 years, 11 months ago (2017-01-03 15:26:09 UTC) #6
Olivier
On 2017/01/03 15:26:09, Nico (ooo sick) wrote: > lgtm, "style guide says so" is a ...
3 years, 11 months ago (2017-01-03 16:28:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606903002/1
3 years, 11 months ago (2017-01-03 16:29:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-03 17:05:30 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 17:07:46 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e148fb50902743d8b41a5b29a7b639e5d2042df
Cr-Commit-Position: refs/heads/master@{#441138}

Powered by Google App Engine
This is Rietveld 408576698