Import Objective C Frameworks in ui/

Import Objective C Frameworks in ui/

The Objective-C frameworks must be imported and not included.
List of Objective-C Frameworks that have been checked:
AVFoundation
AVKit
Accounts
AdSupport
AddressBookUI
AssetsLibrary
CallKit
CloudKit
Contacts
ContactsUI
CoreAudioKit
CoreBluetooth
CoreData
CoreImage
CoreLocation
CoreMIDI
CoreMotion
CoreSpotlight
EventKit
EventKitUI
ExternalAccessory
Foundation
GLKit
GameController
GameKit
GameplayKit
HealthKit
HealthKitUI
HomeKit
Intents
IntentsUI
JavaScriptCore
LocalAuthentication
MapKit
MediaPlayer
MessageUI
Messages
Metal
MetalKit
MetalPerformanceShaders
ModelIO
MultipeerConnectivity
NetworkExtension
NewsstandKit
NotificationCenter
PassKit
Photos
PhotosUI
PushKit
QuickLook
ReplayKit
SafariServices
SceneKit
Social
Speech
SpriteKit
StoreKit
Twitter
UIKit
UserNotifications
UserNotificationsUI
VideoSubscriberAccount
WatchConnectivity
WatchKit
WebKit
iAd

BUG=677965
Committed: https://crrev.com/5e148fb50902743d8b41a5b29a7b639e5d2042df
Cr-Commit-Position: refs/heads/master@{#441138}

[Olivier, 2016-12-28 14:08:20]

olivierrobin@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-01-03 15:09:59]

Does this have any effect in practice? As far as I can tell, clang does the same
thing for #include and #import.

Historically, #import was the same as #include + #pragma once, but modern
compilers have solid implementations of opening .h files from #includes just
once, and for modules both forms are treated the same as far as I know.

I don't have any problems with this CL, just trying to understand the
motivation.

(If you're doing this for several directories, please create a tracking bug and
add BUG= lines to that bug to each CL. Almost every time something spans more
than 1 CL, there should be a tracking bug for it.)

[Olivier, 2017-01-03 15:20:08]

On 2017/01/03 15:09:59, Nico (ooo sick) wrote:
> Does this have any effect in practice? As far as I can tell, clang does the
same
> thing for #include and #import.
> 
> Historically, #import was the same as #include + #pragma once, but modern
> compilers have solid implementations of opening .h files from #includes just
> once, and for modules both forms are treated the same as far as I know.
> 
> I don't have any problems with this CL, just trying to understand the
> motivation.
> 
> (If you're doing this for several directories, please create a tracking bug
and
> add BUG= lines to that bug to each CL. Almost every time something spans more
> than 1 CL, there should be a tracking bug for it.)

Style guide 
https://google.github.io/styleguide/objcguide.xml#_import_and__include
has some arguments.

My motivation is that several of my CLs have been delayed because I had the 
wrong directive.
So I am adding a PRESUBMIT but it needs a clean state to start with.

Added bug

[Olivier, 2017-01-03 15:20:16]

Description was changed from

==========
Import Objective C Frameworks in ui/

The Objective-C frameworks must be imported and not included.
List of Objective-C Frameworks that have been checked:
AVFoundation
AVKit
Accounts
AdSupport
AddressBookUI
AssetsLibrary
CallKit
CloudKit
Contacts
ContactsUI
CoreAudioKit
CoreBluetooth
CoreData
CoreImage
CoreLocation
CoreMIDI
CoreMotion
CoreSpotlight
EventKit
EventKitUI
ExternalAccessory
Foundation
GLKit
GameController
GameKit
GameplayKit
HealthKit
HealthKitUI
HomeKit
Intents
IntentsUI
JavaScriptCore
LocalAuthentication
MapKit
MediaPlayer
MessageUI
Messages
Metal
MetalKit
MetalPerformanceShaders
ModelIO
MultipeerConnectivity
NetworkExtension
NewsstandKit
NotificationCenter
PassKit
Photos
PhotosUI
PushKit
QuickLook
ReplayKit
SafariServices
SceneKit
Social
Speech
SpriteKit
StoreKit
Twitter
UIKit
UserNotifications
UserNotificationsUI
VideoSubscriberAccount
WatchConnectivity
WatchKit
WebKit
iAd

BUG=None
==========

to

==========
Import Objective C Frameworks in ui/

The Objective-C frameworks must be imported and not included.
List of Objective-C Frameworks that have been checked:
AVFoundation
AVKit
Accounts
AdSupport
AddressBookUI
AssetsLibrary
CallKit
CloudKit
Contacts
ContactsUI
CoreAudioKit
CoreBluetooth
CoreData
CoreImage
CoreLocation
CoreMIDI
CoreMotion
CoreSpotlight
EventKit
EventKitUI
ExternalAccessory
Foundation
GLKit
GameController
GameKit
GameplayKit
HealthKit
HealthKitUI
HomeKit
Intents
IntentsUI
JavaScriptCore
LocalAuthentication
MapKit
MediaPlayer
MessageUI
Messages
Metal
MetalKit
MetalPerformanceShaders
ModelIO
MultipeerConnectivity
NetworkExtension
NewsstandKit
NotificationCenter
PassKit
Photos
PhotosUI
PushKit
QuickLook
ReplayKit
SafariServices
SceneKit
Social
Speech
SpriteKit
StoreKit
Twitter
UIKit
UserNotifications
UserNotificationsUI
VideoSubscriberAccount
WatchConnectivity
WatchKit
WebKit
iAd

BUG=677965
==========

[Nico, 2017-01-03 15:26:09]

lgtm, "style guide says so" is a good reason :-)

I'm not sure it's feasible to add a presubmit though; given a .h file how would
you know if it contains objc or c code without looking at the file's contents /
trying to find the matching .cc / .mm file, etc?

[Olivier, 2017-01-03 16:28:59]

On 2017/01/03 15:26:09, Nico (ooo sick) wrote:
> lgtm, "style guide says so" is a good reason :-)
> 
> I'm not sure it's feasible to add a presubmit though; given a .h file how
would
> you know if it contains objc or c code without looking at the file's contents
/
> trying to find the matching .cc / .mm file, etc?

CL to add the presubmit is
https://codereview.chromium.org/2598173002/

The idea is that if the current state is OK, a file is Objective C iff it
contains a
#import, a @ directive (@interface,...) or a block declaration.

So if the current state is fine, you can check most of the includes.

[Olivier, 2017-01-03 16:29:05]

The CQ bit was checked by olivierrobin@chromium.org

[commit-bot: I haz the power, 2017-01-03 16:29:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 17:05:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483460945896520, "parent_rev":
"64292341905703bb79d7a5b540d28cd62d838b94", "commit_rev":
"c9c544f27ff9c433a481fd26837e97a63583edba"}

[commit-bot: I haz the power, 2017-01-03 17:05:29]

Description was changed from

==========
Import Objective C Frameworks in ui/

The Objective-C frameworks must be imported and not included.
List of Objective-C Frameworks that have been checked:
AVFoundation
AVKit
Accounts
AdSupport
AddressBookUI
AssetsLibrary
CallKit
CloudKit
Contacts
ContactsUI
CoreAudioKit
CoreBluetooth
CoreData
CoreImage
CoreLocation
CoreMIDI
CoreMotion
CoreSpotlight
EventKit
EventKitUI
ExternalAccessory
Foundation
GLKit
GameController
GameKit
GameplayKit
HealthKit
HealthKitUI
HomeKit
Intents
IntentsUI
JavaScriptCore
LocalAuthentication
MapKit
MediaPlayer
MessageUI
Messages
Metal
MetalKit
MetalPerformanceShaders
ModelIO
MultipeerConnectivity
NetworkExtension
NewsstandKit
NotificationCenter
PassKit
Photos
PhotosUI
PushKit
QuickLook
ReplayKit
SafariServices
SceneKit
Social
Speech
SpriteKit
StoreKit
Twitter
UIKit
UserNotifications
UserNotificationsUI
VideoSubscriberAccount
WatchConnectivity
WatchKit
WebKit
iAd

BUG=677965
==========

to

==========
Import Objective C Frameworks in ui/

The Objective-C frameworks must be imported and not included.
List of Objective-C Frameworks that have been checked:
AVFoundation
AVKit
Accounts
AdSupport
AddressBookUI
AssetsLibrary
CallKit
CloudKit
Contacts
ContactsUI
CoreAudioKit
CoreBluetooth
CoreData
CoreImage
CoreLocation
CoreMIDI
CoreMotion
CoreSpotlight
EventKit
EventKitUI
ExternalAccessory
Foundation
GLKit
GameController
GameKit
GameplayKit
HealthKit
HealthKitUI
HomeKit
Intents
IntentsUI
JavaScriptCore
LocalAuthentication
MapKit
MediaPlayer
MessageUI
Messages
Metal
MetalKit
MetalPerformanceShaders
ModelIO
MultipeerConnectivity
NetworkExtension
NewsstandKit
NotificationCenter
PassKit
Photos
PhotosUI
PushKit
QuickLook
ReplayKit
SafariServices
SceneKit
Social
Speech
SpriteKit
StoreKit
Twitter
UIKit
UserNotifications
UserNotificationsUI
VideoSubscriberAccount
WatchConnectivity
WatchKit
WebKit
iAd

BUG=677965

Review-Url: https://codereview.chromium.org/2606903002
==========

[commit-bot: I haz the power, 2017-01-03 17:05:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-03 17:07:45]

Description was changed from

==========
Import Objective C Frameworks in ui/

The Objective-C frameworks must be imported and not included.
List of Objective-C Frameworks that have been checked:
AVFoundation
AVKit
Accounts
AdSupport
AddressBookUI
AssetsLibrary
CallKit
CloudKit
Contacts
ContactsUI
CoreAudioKit
CoreBluetooth
CoreData
CoreImage
CoreLocation
CoreMIDI
CoreMotion
CoreSpotlight
EventKit
EventKitUI
ExternalAccessory
Foundation
GLKit
GameController
GameKit
GameplayKit
HealthKit
HealthKitUI
HomeKit
Intents
IntentsUI
JavaScriptCore
LocalAuthentication
MapKit
MediaPlayer
MessageUI
Messages
Metal
MetalKit
MetalPerformanceShaders
ModelIO
MultipeerConnectivity
NetworkExtension
NewsstandKit
NotificationCenter
PassKit
Photos
PhotosUI
PushKit
QuickLook
ReplayKit
SafariServices
SceneKit
Social
Speech
SpriteKit
StoreKit
Twitter
UIKit
UserNotifications
UserNotificationsUI
VideoSubscriberAccount
WatchConnectivity
WatchKit
WebKit
iAd

BUG=677965

Review-Url: https://codereview.chromium.org/2606903002
==========

to

==========
Import Objective C Frameworks in ui/

The Objective-C frameworks must be imported and not included.
List of Objective-C Frameworks that have been checked:
AVFoundation
AVKit
Accounts
AdSupport
AddressBookUI
AssetsLibrary
CallKit
CloudKit
Contacts
ContactsUI
CoreAudioKit
CoreBluetooth
CoreData
CoreImage
CoreLocation
CoreMIDI
CoreMotion
CoreSpotlight
EventKit
EventKitUI
ExternalAccessory
Foundation
GLKit
GameController
GameKit
GameplayKit
HealthKit
HealthKitUI
HomeKit
Intents
IntentsUI
JavaScriptCore
LocalAuthentication
MapKit
MediaPlayer
MessageUI
Messages
Metal
MetalKit
MetalPerformanceShaders
ModelIO
MultipeerConnectivity
NetworkExtension
NewsstandKit
NotificationCenter
PassKit
Photos
PhotosUI
PushKit
QuickLook
ReplayKit
SafariServices
SceneKit
Social
Speech
SpriteKit
StoreKit
Twitter
UIKit
UserNotifications
UserNotificationsUI
VideoSubscriberAccount
WatchConnectivity
WatchKit
WebKit
iAd

BUG=677965

Committed: https://crrev.com/5e148fb50902743d8b41a5b29a7b639e5d2042df
Cr-Commit-Position: refs/heads/master@{#441138}
==========

[commit-bot: I haz the power, 2017-01-03 17:07:46]

Patchset 1 (id:??) landed as
https://crrev.com/5e148fb50902743d8b41a5b29a7b639e5d2042df
Cr-Commit-Position: refs/heads/master@{#441138}