Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2606893002: [csa] More conservative propagation of flag marking blocks needing frames (Closed)

Created:
3 years, 11 months ago by danno
Modified:
3 years, 11 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[csa] More conservative propagation of flag marking blocks needing frames Specifically, don't propage "needs_frame" up through non-deferred -> deferred block transitions where there are multiple edges from the non-deferred to deferred code. LOG=N R=epertoso@chromium.org Review-Url: https://codereview.chromium.org/2606893002 Cr-Commit-Position: refs/heads/master@{#41972} Committed: https://chromium.googlesource.com/v8/v8/+/505cfdd84d3e6f9859c2dd51fa8e27611164e4d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M src/compiler/frame-elider.cc View 1 chunk +29 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
epertoso
lgtm
3 years, 11 months ago (2016-12-28 14:00:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606893002/1
3 years, 11 months ago (2016-12-28 14:16:01 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2016-12-28 14:17:42 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/505cfdd84d3e6f9859c2dd51fa8e2761116...

Powered by Google App Engine
This is Rietveld 408576698