Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 2606863003: Remove an isContextInitialized() check from WindowProxyManager::updateSecurityOrigin() (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove an isContextInitialized() check from WindowProxyManager::updateSecurityOrigin() The check is not needed since it is already checked in WindowProxy::updateSecurityOrigin(). BUG=677253 Review-Url: https://codereview.chromium.org/2606863003 Cr-Commit-Position: refs/heads/master@{#441640} Committed: https://chromium.googlesource.com/chromium/src/+/b336c47b04fb8a5d5508397496d7c1e58e5681ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
haraken
PTAL
3 years, 11 months ago (2016-12-28 08:36:23 UTC) #2
Yuki
LGTM.
3 years, 11 months ago (2016-12-28 08:47:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606863003/1
3 years, 11 months ago (2017-01-05 09:19:40 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 12:53:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b336c47b04fb8a5d5508397496d7...

Powered by Google App Engine
This is Rietveld 408576698