Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2606853002: SELECT popup: Don't use non-100% zoom level in popup. (Closed)

Created:
3 years, 12 months ago by tkent
Modified:
3 years, 11 months ago
Reviewers:
keishi
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SELECT popup: Don't use non-100% zoom level in popup. This CL reverts a SELECT popup part of [1], which applied page zoom to page popups, and we pass zoomed font-size after this CL. [1] made multiple regressions, and it's hard to fix them in non-100% zoom level. * Make PagePopupClient::zoomFactor() virtual, and SELECT popups return 1.0 for it. * Fix code and comments on screen coordinate. * Popup border ignores device scale factor and page zoom, and is always 1px width. [1] codereview.chromium.org/1454613002 BUG=564506, 570636, 595986 Committed: https://crrev.com/421bed44b76d7743b573b4a6b313fa17813f8416 Cr-Commit-Position: refs/heads/master@{#441335}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -43 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-appearance-zoom090.html View 1 chunk +0 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-appearance-zoom110.html View 1 chunk +19 lines, -11 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-appearance-zoom110-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-appearance-zoom110-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/forms/select-popup/popup-menu-appearance-zoom-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/forms/select-popup/popup-menu-appearance-zoom090-expected.png View Binary file 0 comments Download
M third_party/WebKit/Source/core/page/PagePopupClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 3 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/resources/listPicker.js View 2 chunks +15 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/web/resources/pickerCommon.js View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
tkent
keishi@, would you review this please?
3 years, 12 months ago (2016-12-28 07:44:35 UTC) #7
keishi
LGTM
3 years, 11 months ago (2017-01-04 03:36:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606853002/20001
3 years, 11 months ago (2017-01-04 04:21:41 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
3 years, 11 months ago (2017-01-04 07:49:32 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 07:54:03 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/421bed44b76d7743b573b4a6b313fa17813f8416
Cr-Commit-Position: refs/heads/master@{#441335}

Powered by Google App Engine
This is Rietveld 408576698