Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: src/full-codegen/x87/full-codegen-x87.cc

Issue 2606833002: [ESnext] Implement Object spread (Closed)
Patch Set: fix test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/ast/compile-time-value.h" 7 #include "src/ast/compile-time-value.h"
8 #include "src/ast/scopes.h" 8 #include "src/ast/scopes.h"
9 #include "src/builtins/builtins-constructor.h" 9 #include "src/builtins/builtins-constructor.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1147 matching lines...) Expand 10 before | Expand all | Expand 10 after
1158 DCHECK(!property->is_computed_name()); 1158 DCHECK(!property->is_computed_name());
1159 if (property->IsCompileTimeValue()) continue; 1159 if (property->IsCompileTimeValue()) continue;
1160 1160
1161 Literal* key = property->key()->AsLiteral(); 1161 Literal* key = property->key()->AsLiteral();
1162 Expression* value = property->value(); 1162 Expression* value = property->value();
1163 if (!result_saved) { 1163 if (!result_saved) {
1164 PushOperand(eax); // Save result on the stack 1164 PushOperand(eax); // Save result on the stack
1165 result_saved = true; 1165 result_saved = true;
1166 } 1166 }
1167 switch (property->kind()) { 1167 switch (property->kind()) {
1168 case ObjectLiteral::Property::SPREAD:
1168 case ObjectLiteral::Property::CONSTANT: 1169 case ObjectLiteral::Property::CONSTANT:
1169 UNREACHABLE(); 1170 UNREACHABLE();
1170 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1171 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1171 DCHECK(!CompileTimeValue::IsCompileTimeValue(value)); 1172 DCHECK(!CompileTimeValue::IsCompileTimeValue(value));
1172 // Fall through. 1173 // Fall through.
1173 case ObjectLiteral::Property::COMPUTED: 1174 case ObjectLiteral::Property::COMPUTED:
1174 // It is safe to use [[Put]] here because the boilerplate already 1175 // It is safe to use [[Put]] here because the boilerplate already
1175 // contains computed properties with an uninitialized value. 1176 // contains computed properties with an uninitialized value.
1176 if (key->IsStringLiteral()) { 1177 if (key->IsStringLiteral()) {
1177 DCHECK(key->IsPropertyName()); 1178 DCHECK(key->IsPropertyName());
(...skipping 1608 matching lines...) Expand 10 before | Expand all | Expand 10 after
2786 isolate->builtins()->OnStackReplacement()->entry(), 2787 isolate->builtins()->OnStackReplacement()->entry(),
2787 Assembler::target_address_at(call_target_address, unoptimized_code)); 2788 Assembler::target_address_at(call_target_address, unoptimized_code));
2788 return ON_STACK_REPLACEMENT; 2789 return ON_STACK_REPLACEMENT;
2789 } 2790 }
2790 2791
2791 2792
2792 } // namespace internal 2793 } // namespace internal
2793 } // namespace v8 2794 } // namespace v8
2794 2795
2795 #endif // V8_TARGET_ARCH_X87 2796 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698