Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Side by Side Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 2606833002: [ESnext] Implement Object spread (Closed)
Patch Set: fix test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/s390/full-codegen-s390.cc ('k') | src/full-codegen/x87/full-codegen-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/ast/compile-time-value.h" 7 #include "src/ast/compile-time-value.h"
8 #include "src/ast/scopes.h" 8 #include "src/ast/scopes.h"
9 #include "src/builtins/builtins-constructor.h" 9 #include "src/builtins/builtins-constructor.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1184 matching lines...) Expand 10 before | Expand all | Expand 10 after
1195 DCHECK(!property->is_computed_name()); 1195 DCHECK(!property->is_computed_name());
1196 if (property->IsCompileTimeValue()) continue; 1196 if (property->IsCompileTimeValue()) continue;
1197 1197
1198 Literal* key = property->key()->AsLiteral(); 1198 Literal* key = property->key()->AsLiteral();
1199 Expression* value = property->value(); 1199 Expression* value = property->value();
1200 if (!result_saved) { 1200 if (!result_saved) {
1201 PushOperand(rax); // Save result on the stack 1201 PushOperand(rax); // Save result on the stack
1202 result_saved = true; 1202 result_saved = true;
1203 } 1203 }
1204 switch (property->kind()) { 1204 switch (property->kind()) {
1205 case ObjectLiteral::Property::SPREAD:
1205 case ObjectLiteral::Property::CONSTANT: 1206 case ObjectLiteral::Property::CONSTANT:
1206 UNREACHABLE(); 1207 UNREACHABLE();
1207 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1208 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1208 DCHECK(!CompileTimeValue::IsCompileTimeValue(value)); 1209 DCHECK(!CompileTimeValue::IsCompileTimeValue(value));
1209 // Fall through. 1210 // Fall through.
1210 case ObjectLiteral::Property::COMPUTED: 1211 case ObjectLiteral::Property::COMPUTED:
1211 // It is safe to use [[Put]] here because the boilerplate already 1212 // It is safe to use [[Put]] here because the boilerplate already
1212 // contains computed properties with an uninitialized value. 1213 // contains computed properties with an uninitialized value.
1213 if (key->IsStringLiteral()) { 1214 if (key->IsStringLiteral()) {
1214 DCHECK(key->IsPropertyName()); 1215 DCHECK(key->IsPropertyName());
(...skipping 1561 matching lines...) Expand 10 before | Expand all | Expand 10 after
2776 DCHECK_EQ( 2777 DCHECK_EQ(
2777 isolate->builtins()->OnStackReplacement()->entry(), 2778 isolate->builtins()->OnStackReplacement()->entry(),
2778 Assembler::target_address_at(call_target_address, unoptimized_code)); 2779 Assembler::target_address_at(call_target_address, unoptimized_code));
2779 return ON_STACK_REPLACEMENT; 2780 return ON_STACK_REPLACEMENT;
2780 } 2781 }
2781 2782
2782 } // namespace internal 2783 } // namespace internal
2783 } // namespace v8 2784 } // namespace v8
2784 2785
2785 #endif // V8_TARGET_ARCH_X64 2786 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/full-codegen/s390/full-codegen-s390.cc ('k') | src/full-codegen/x87/full-codegen-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698