Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: src/full-codegen/s390/full-codegen-s390.cc

Issue 2606833002: [ESnext] Implement Object spread (Closed)
Patch Set: fix test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_S390 5 #if V8_TARGET_ARCH_S390
6 6
7 #include "src/ast/compile-time-value.h" 7 #include "src/ast/compile-time-value.h"
8 #include "src/ast/scopes.h" 8 #include "src/ast/scopes.h"
9 #include "src/builtins/builtins-constructor.h" 9 #include "src/builtins/builtins-constructor.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1158 matching lines...) Expand 10 before | Expand all | Expand 10 after
1169 DCHECK(!property->is_computed_name()); 1169 DCHECK(!property->is_computed_name());
1170 if (property->IsCompileTimeValue()) continue; 1170 if (property->IsCompileTimeValue()) continue;
1171 1171
1172 Literal* key = property->key()->AsLiteral(); 1172 Literal* key = property->key()->AsLiteral();
1173 Expression* value = property->value(); 1173 Expression* value = property->value();
1174 if (!result_saved) { 1174 if (!result_saved) {
1175 PushOperand(r2); // Save result on stack 1175 PushOperand(r2); // Save result on stack
1176 result_saved = true; 1176 result_saved = true;
1177 } 1177 }
1178 switch (property->kind()) { 1178 switch (property->kind()) {
1179 case ObjectLiteral::Property::SPREAD:
1179 case ObjectLiteral::Property::CONSTANT: 1180 case ObjectLiteral::Property::CONSTANT:
1180 UNREACHABLE(); 1181 UNREACHABLE();
1181 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1182 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1182 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value())); 1183 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value()));
1183 // Fall through. 1184 // Fall through.
1184 case ObjectLiteral::Property::COMPUTED: 1185 case ObjectLiteral::Property::COMPUTED:
1185 // It is safe to use [[Put]] here because the boilerplate already 1186 // It is safe to use [[Put]] here because the boilerplate already
1186 // contains computed properties with an uninitialized value. 1187 // contains computed properties with an uninitialized value.
1187 if (key->IsStringLiteral()) { 1188 if (key->IsStringLiteral()) {
1188 DCHECK(key->IsPropertyName()); 1189 DCHECK(key->IsPropertyName());
(...skipping 1610 matching lines...) Expand 10 before | Expand all | Expand 10 after
2799 DCHECK(kOSRBranchInstruction == br_instr); 2800 DCHECK(kOSRBranchInstruction == br_instr);
2800 2801
2801 DCHECK(interrupt_address == 2802 DCHECK(interrupt_address ==
2802 isolate->builtins()->OnStackReplacement()->entry()); 2803 isolate->builtins()->OnStackReplacement()->entry());
2803 return ON_STACK_REPLACEMENT; 2804 return ON_STACK_REPLACEMENT;
2804 } 2805 }
2805 2806
2806 } // namespace internal 2807 } // namespace internal
2807 } // namespace v8 2808 } // namespace v8
2808 #endif // V8_TARGET_ARCH_S390 2809 #endif // V8_TARGET_ARCH_S390
OLDNEW
« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698