Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/full-codegen/ppc/full-codegen-ppc.cc

Issue 2606833002: [ESnext] Implement Object spread (Closed)
Patch Set: fix test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_PPC 5 #if V8_TARGET_ARCH_PPC
6 6
7 #include "src/ast/compile-time-value.h" 7 #include "src/ast/compile-time-value.h"
8 #include "src/ast/scopes.h" 8 #include "src/ast/scopes.h"
9 #include "src/builtins/builtins-constructor.h" 9 #include "src/builtins/builtins-constructor.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1195 matching lines...) Expand 10 before | Expand all | Expand 10 after
1206 DCHECK(!property->is_computed_name()); 1206 DCHECK(!property->is_computed_name());
1207 if (property->IsCompileTimeValue()) continue; 1207 if (property->IsCompileTimeValue()) continue;
1208 1208
1209 Literal* key = property->key()->AsLiteral(); 1209 Literal* key = property->key()->AsLiteral();
1210 Expression* value = property->value(); 1210 Expression* value = property->value();
1211 if (!result_saved) { 1211 if (!result_saved) {
1212 PushOperand(r3); // Save result on stack 1212 PushOperand(r3); // Save result on stack
1213 result_saved = true; 1213 result_saved = true;
1214 } 1214 }
1215 switch (property->kind()) { 1215 switch (property->kind()) {
1216 case ObjectLiteral::Property::SPREAD:
1216 case ObjectLiteral::Property::CONSTANT: 1217 case ObjectLiteral::Property::CONSTANT:
1217 UNREACHABLE(); 1218 UNREACHABLE();
1218 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1219 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1219 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value())); 1220 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value()));
1220 // Fall through. 1221 // Fall through.
1221 case ObjectLiteral::Property::COMPUTED: 1222 case ObjectLiteral::Property::COMPUTED:
1222 // It is safe to use [[Put]] here because the boilerplate already 1223 // It is safe to use [[Put]] here because the boilerplate already
1223 // contains computed properties with an uninitialized value. 1224 // contains computed properties with an uninitialized value.
1224 if (key->IsStringLiteral()) { 1225 if (key->IsStringLiteral()) {
1225 DCHECK(key->IsPropertyName()); 1226 DCHECK(key->IsPropertyName());
(...skipping 1636 matching lines...) Expand 10 before | Expand all | Expand 10 after
2862 2863
2863 DCHECK(Assembler::IsCrSet(Assembler::instr_at(cmp_address))); 2864 DCHECK(Assembler::IsCrSet(Assembler::instr_at(cmp_address)));
2864 2865
2865 DCHECK(interrupt_address == 2866 DCHECK(interrupt_address ==
2866 isolate->builtins()->OnStackReplacement()->entry()); 2867 isolate->builtins()->OnStackReplacement()->entry());
2867 return ON_STACK_REPLACEMENT; 2868 return ON_STACK_REPLACEMENT;
2868 } 2869 }
2869 } // namespace internal 2870 } // namespace internal
2870 } // namespace v8 2871 } // namespace v8
2871 #endif // V8_TARGET_ARCH_PPC 2872 #endif // V8_TARGET_ARCH_PPC
OLDNEW
« no previous file with comments | « src/full-codegen/mips64/full-codegen-mips64.cc ('k') | src/full-codegen/s390/full-codegen-s390.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698