Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: src/full-codegen/mips64/full-codegen-mips64.cc

Issue 2606833002: [ESnext] Implement Object spread (Closed)
Patch Set: fix test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 1225 matching lines...) Expand 10 before | Expand all | Expand 10 after
1236 DCHECK(!property->is_computed_name()); 1236 DCHECK(!property->is_computed_name());
1237 if (property->IsCompileTimeValue()) continue; 1237 if (property->IsCompileTimeValue()) continue;
1238 1238
1239 Literal* key = property->key()->AsLiteral(); 1239 Literal* key = property->key()->AsLiteral();
1240 Expression* value = property->value(); 1240 Expression* value = property->value();
1241 if (!result_saved) { 1241 if (!result_saved) {
1242 PushOperand(v0); // Save result on stack. 1242 PushOperand(v0); // Save result on stack.
1243 result_saved = true; 1243 result_saved = true;
1244 } 1244 }
1245 switch (property->kind()) { 1245 switch (property->kind()) {
1246 case ObjectLiteral::Property::SPREAD:
1246 case ObjectLiteral::Property::CONSTANT: 1247 case ObjectLiteral::Property::CONSTANT:
1247 UNREACHABLE(); 1248 UNREACHABLE();
1248 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1249 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1249 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value())); 1250 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value()));
1250 // Fall through. 1251 // Fall through.
1251 case ObjectLiteral::Property::COMPUTED: 1252 case ObjectLiteral::Property::COMPUTED:
1252 // It is safe to use [[Put]] here because the boilerplate already 1253 // It is safe to use [[Put]] here because the boilerplate already
1253 // contains computed properties with an uninitialized value. 1254 // contains computed properties with an uninitialized value.
1254 if (key->IsStringLiteral()) { 1255 if (key->IsStringLiteral()) {
1255 DCHECK(key->IsPropertyName()); 1256 DCHECK(key->IsPropertyName());
(...skipping 1636 matching lines...) Expand 10 before | Expand all | Expand 10 after
2892 reinterpret_cast<uint64_t>( 2893 reinterpret_cast<uint64_t>(
2893 isolate->builtins()->OnStackReplacement()->entry())); 2894 isolate->builtins()->OnStackReplacement()->entry()));
2894 return ON_STACK_REPLACEMENT; 2895 return ON_STACK_REPLACEMENT;
2895 } 2896 }
2896 2897
2897 2898
2898 } // namespace internal 2899 } // namespace internal
2899 } // namespace v8 2900 } // namespace v8
2900 2901
2901 #endif // V8_TARGET_ARCH_MIPS64 2902 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698