Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 2606833002: [ESnext] Implement Object spread (Closed)
Patch Set: fix test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 1223 matching lines...) Expand 10 before | Expand all | Expand 10 after
1234 DCHECK(!property->is_computed_name()); 1234 DCHECK(!property->is_computed_name());
1235 if (property->IsCompileTimeValue()) continue; 1235 if (property->IsCompileTimeValue()) continue;
1236 1236
1237 Literal* key = property->key()->AsLiteral(); 1237 Literal* key = property->key()->AsLiteral();
1238 Expression* value = property->value(); 1238 Expression* value = property->value();
1239 if (!result_saved) { 1239 if (!result_saved) {
1240 PushOperand(v0); // Save result on stack. 1240 PushOperand(v0); // Save result on stack.
1241 result_saved = true; 1241 result_saved = true;
1242 } 1242 }
1243 switch (property->kind()) { 1243 switch (property->kind()) {
1244 case ObjectLiteral::Property::SPREAD:
1244 case ObjectLiteral::Property::CONSTANT: 1245 case ObjectLiteral::Property::CONSTANT:
1245 UNREACHABLE(); 1246 UNREACHABLE();
1246 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1247 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1247 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value())); 1248 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value()));
1248 // Fall through. 1249 // Fall through.
1249 case ObjectLiteral::Property::COMPUTED: 1250 case ObjectLiteral::Property::COMPUTED:
1250 // It is safe to use [[Put]] here because the boilerplate already 1251 // It is safe to use [[Put]] here because the boilerplate already
1251 // contains computed properties with an uninitialized value. 1252 // contains computed properties with an uninitialized value.
1252 if (key->IsStringLiteral()) { 1253 if (key->IsStringLiteral()) {
1253 DCHECK(key->IsPropertyName()); 1254 DCHECK(key->IsPropertyName());
(...skipping 1629 matching lines...) Expand 10 before | Expand all | Expand 10 after
2883 reinterpret_cast<uint32_t>( 2884 reinterpret_cast<uint32_t>(
2884 isolate->builtins()->OnStackReplacement()->entry())); 2885 isolate->builtins()->OnStackReplacement()->entry()));
2885 return ON_STACK_REPLACEMENT; 2886 return ON_STACK_REPLACEMENT;
2886 } 2887 }
2887 2888
2888 2889
2889 } // namespace internal 2890 } // namespace internal
2890 } // namespace v8 2891 } // namespace v8
2891 2892
2892 #endif // V8_TARGET_ARCH_MIPS 2893 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/full-codegen/ia32/full-codegen-ia32.cc ('k') | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698