Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: src/full-codegen/arm64/full-codegen-arm64.cc

Issue 2606833002: [ESnext] Implement Object spread (Closed)
Patch Set: fix test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/ast/compile-time-value.h" 7 #include "src/ast/compile-time-value.h"
8 #include "src/ast/scopes.h" 8 #include "src/ast/scopes.h"
9 #include "src/builtins/builtins-constructor.h" 9 #include "src/builtins/builtins-constructor.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1211 matching lines...) Expand 10 before | Expand all | Expand 10 after
1222 DCHECK(!property->is_computed_name()); 1222 DCHECK(!property->is_computed_name());
1223 if (property->IsCompileTimeValue()) continue; 1223 if (property->IsCompileTimeValue()) continue;
1224 1224
1225 Literal* key = property->key()->AsLiteral(); 1225 Literal* key = property->key()->AsLiteral();
1226 Expression* value = property->value(); 1226 Expression* value = property->value();
1227 if (!result_saved) { 1227 if (!result_saved) {
1228 PushOperand(x0); // Save result on stack 1228 PushOperand(x0); // Save result on stack
1229 result_saved = true; 1229 result_saved = true;
1230 } 1230 }
1231 switch (property->kind()) { 1231 switch (property->kind()) {
1232 case ObjectLiteral::Property::SPREAD:
1232 case ObjectLiteral::Property::CONSTANT: 1233 case ObjectLiteral::Property::CONSTANT:
1233 UNREACHABLE(); 1234 UNREACHABLE();
1234 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1235 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1235 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value())); 1236 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value()));
1236 // Fall through. 1237 // Fall through.
1237 case ObjectLiteral::Property::COMPUTED: 1238 case ObjectLiteral::Property::COMPUTED:
1238 // It is safe to use [[Put]] here because the boilerplate already 1239 // It is safe to use [[Put]] here because the boilerplate already
1239 // contains computed properties with an uninitialized value. 1240 // contains computed properties with an uninitialized value.
1240 if (key->IsStringLiteral()) { 1241 if (key->IsStringLiteral()) {
1241 DCHECK(key->IsPropertyName()); 1242 DCHECK(key->IsPropertyName());
(...skipping 1682 matching lines...) Expand 10 before | Expand all | Expand 10 after
2924 } 2925 }
2925 2926
2926 return INTERRUPT; 2927 return INTERRUPT;
2927 } 2928 }
2928 2929
2929 2930
2930 } // namespace internal 2931 } // namespace internal
2931 } // namespace v8 2932 } // namespace v8
2932 2933
2933 #endif // V8_TARGET_ARCH_ARM64 2934 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698