Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 2606833002: [ESnext] Implement Object spread (Closed)
Patch Set: fix test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/flag-definitions.h ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/ast/compile-time-value.h" 7 #include "src/ast/compile-time-value.h"
8 #include "src/ast/scopes.h" 8 #include "src/ast/scopes.h"
9 #include "src/builtins/builtins-constructor.h" 9 #include "src/builtins/builtins-constructor.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1224 matching lines...) Expand 10 before | Expand all | Expand 10 after
1235 DCHECK(!property->is_computed_name()); 1235 DCHECK(!property->is_computed_name());
1236 if (property->IsCompileTimeValue()) continue; 1236 if (property->IsCompileTimeValue()) continue;
1237 1237
1238 Literal* key = property->key()->AsLiteral(); 1238 Literal* key = property->key()->AsLiteral();
1239 Expression* value = property->value(); 1239 Expression* value = property->value();
1240 if (!result_saved) { 1240 if (!result_saved) {
1241 PushOperand(r0); // Save result on stack 1241 PushOperand(r0); // Save result on stack
1242 result_saved = true; 1242 result_saved = true;
1243 } 1243 }
1244 switch (property->kind()) { 1244 switch (property->kind()) {
1245 case ObjectLiteral::Property::SPREAD:
1245 case ObjectLiteral::Property::CONSTANT: 1246 case ObjectLiteral::Property::CONSTANT:
1246 UNREACHABLE(); 1247 UNREACHABLE();
1247 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1248 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1248 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value())); 1249 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value()));
1249 // Fall through. 1250 // Fall through.
1250 case ObjectLiteral::Property::COMPUTED: 1251 case ObjectLiteral::Property::COMPUTED:
1251 // It is safe to use [[Put]] here because the boilerplate already 1252 // It is safe to use [[Put]] here because the boilerplate already
1252 // contains computed properties with an uninitialized value. 1253 // contains computed properties with an uninitialized value.
1253 if (key->IsStringLiteral()) { 1254 if (key->IsStringLiteral()) {
1254 DCHECK(key->IsPropertyName()); 1255 DCHECK(key->IsPropertyName());
(...skipping 1668 matching lines...) Expand 10 before | Expand all | Expand 10 after
2923 DCHECK(interrupt_address == 2924 DCHECK(interrupt_address ==
2924 isolate->builtins()->OnStackReplacement()->entry()); 2925 isolate->builtins()->OnStackReplacement()->entry());
2925 return ON_STACK_REPLACEMENT; 2926 return ON_STACK_REPLACEMENT;
2926 } 2927 }
2927 2928
2928 2929
2929 } // namespace internal 2930 } // namespace internal
2930 } // namespace v8 2931 } // namespace v8
2931 2932
2932 #endif // V8_TARGET_ARCH_ARM 2933 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/flag-definitions.h ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698