Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2606813002:
Add login url to 401 messages (Closed)
|
Created:
3 years, 12 months ago by Ryan Tseng Modified:
3 years, 11 months ago CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org Target Ref:
refs/heads/master Project:
luci-go Visibility:
Public. |
DescriptionAdd login url to 401 messages
BUG=671741
Review-Url: https://codereview.chromium.org/2606813002
Committed: https://github.com/luci/luci-go/commit/cc2b303de7a9dd94840f1f0c161093bad0b77196
Patch Set 1 #Patch Set 2 : train #
Total comments: 2
Patch Set 3 : review #Messages
Total messages: 21 (16 generated)
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Luci-go Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/335b324847fcfb10)
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
hinoka@chromium.org changed reviewers: + estaab@chromium.org, hinoka@chromium.org
ptal, looks a little hacky since it drops the message, tho this might actually be better.
lgtm https://codereview.chromium.org/2606813002/diff/20001/milo/appengine/frontend... File milo/appengine/frontend/templates/buildbot/pages/error.html (right): https://codereview.chromium.org/2606813002/diff/20001/milo/appengine/frontend... milo/appengine/frontend/templates/buildbot/pages/error.html:8: You are not authenticated, please try <a href="{{.LoginURL}}">logging in</a> The message block uses a div, do we need that here too?
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2606813002/diff/20001/milo/appengine/frontend... File milo/appengine/frontend/templates/buildbot/pages/error.html (right): https://codereview.chromium.org/2606813002/diff/20001/milo/appengine/frontend... milo/appengine/frontend/templates/buildbot/pages/error.html:8: You are not authenticated, please try <a href="{{.LoginURL}}">logging in</a> On 2016/12/28 20:05:28, estaab wrote: > The message block uses a div, do we need that here too? Done.
The CQ bit was unchecked by hinoka@chromium.org
The CQ bit was checked by hinoka@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from estaab@chromium.org Link to the patchset: https://codereview.chromium.org/2606813002/#ps40001 (title: "review")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482966953338940,
"parent_rev": "22f07dcc7332d02ae1ef05afef33c7acc743657a", "commit_rev":
"cc2b303de7a9dd94840f1f0c161093bad0b77196"}
Message was sent while issue was closed.
Description was changed from ========== Add login url to 401 messages BUG=671741 ========== to ========== Add login url to 401 messages BUG=671741 Review-Url: https://codereview.chromium.org/2606813002 Committed: https://github.com/luci/luci-go/commit/cc2b303de7a9dd94840f1f0c161093bad0b77196 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://github.com/luci/luci-go/commit/cc2b303de7a9dd94840f1f0c161093bad0b77196 |
