Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2606783002:
Make DirectX Capturer Default On (Closed)
|
Created:
3 years, 11 months ago by qiangchen Modified:
3 years, 11 months ago Reviewers:
Sergey Ulanov CC:
chromium-reviews, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake DirectX Capturer Default On
After monitoring the finch alert for a month, we found the DirectX Capturer works well. This CL brings flag to be default enabled.
BUG=314516
Committed: https://crrev.com/cc10ca6c0767a9b1c4d7e4b9bad73cd8fa1140c6
Cr-Commit-Position: refs/heads/master@{#440856}
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
Description was changed from ========== Make DirectX Capturer Default On BUG= ========== to ========== Make DirectX Capturer Default On After monitoring the finch alert for a month, we found the DirectX Capturer works well. This CL brings flag to be default enabled. BUG=314516 ==========
qiangchen@chromium.org changed reviewers: + sergeyu@chromium.org
The CQ bit was checked by qiangchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Can you take a look?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
On 2016/12/27 18:24:24, Sergey Ulanov wrote: > lgtm I think BUG=663073 would be a better one to reference in this CL. 314516 is marked as fixed.
The CQ bit was checked by qiangchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482943974994810, "parent_rev":
"115d932967039786a76a85e2d4c14362c236e683", "commit_rev":
"4cf98e051651ea4815d7696b8cff4e0551a98519"}
Message was sent while issue was closed.
Description was changed from ========== Make DirectX Capturer Default On After monitoring the finch alert for a month, we found the DirectX Capturer works well. This CL brings flag to be default enabled. BUG=314516 ========== to ========== Make DirectX Capturer Default On After monitoring the finch alert for a month, we found the DirectX Capturer works well. This CL brings flag to be default enabled. BUG=314516 Review-Url: https://codereview.chromium.org/2606783002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Make DirectX Capturer Default On After monitoring the finch alert for a month, we found the DirectX Capturer works well. This CL brings flag to be default enabled. BUG=314516 Review-Url: https://codereview.chromium.org/2606783002 ========== to ========== Make DirectX Capturer Default On After monitoring the finch alert for a month, we found the DirectX Capturer works well. This CL brings flag to be default enabled. BUG=314516 Committed: https://crrev.com/cc10ca6c0767a9b1c4d7e4b9bad73cd8fa1140c6 Cr-Commit-Position: refs/heads/master@{#440856} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/cc10ca6c0767a9b1c4d7e4b9bad73cd8fa1140c6 Cr-Commit-Position: refs/heads/master@{#440856}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2653953004/ by qiangchen@chromium.org. The reason for reverting is: Several bugs are found with DirectX Capturer.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
