Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2606763002: Delete DOMPoint constructor using DOMPointInit as parameter. (Closed)

Created:
3 years, 11 months ago by Byoungkwon Ko
Modified:
3 years, 11 months ago
Reviewers:
haraken, zino
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete DOMPoint constructor using DOMPointInit as parameter. Delete DOMPoint constructor using DOMPointInit as parameter. DOMPoint interfaces do not need the constructor anymore as following spec[1]. This patch doesn't break the existing web because DOMPoint is still behind the runtime flag. [1] https://drafts.fxtf.org/geometry/#dom-dompoint-dompoint BUG=675437 Committed: https://crrev.com/e14a6ca3bed003384db8a69064fbbb9cd2a533d6 Cr-Commit-Position: refs/heads/master@{#441099}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Delete DOMPoint constructor using DOMPointInit as parameter. #

Total comments: 4

Patch Set 3 : Delete DOMPoint constructor using DOMPointInit as parameter. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point.html View 1 2 1 chunk +0 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMPoint.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMPoint.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMPoint.idl View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
zino
lgtm with nit. You will have to update webexposed test before landing this patch. Also, ...
3 years, 11 months ago (2016-12-30 08:04:24 UTC) #2
Byoungkwon Ko
3 years, 11 months ago (2016-12-30 18:30:59 UTC) #4
Byoungkwon Ko
I deleted the comment. Thanks.
3 years, 11 months ago (2016-12-30 19:10:48 UTC) #5
haraken
LGTM
3 years, 11 months ago (2016-12-31 00:29:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606763002/20001
3 years, 11 months ago (2016-12-31 01:58:33 UTC) #9
zino
Please update CL description as per my previous comment. https://codereview.chromium.org/2606763002/diff/20001/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point.html File third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point.html (left): https://codereview.chromium.org/2606763002/diff/20001/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point.html#oldcode29 third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point.html:29: ...
3 years, 11 months ago (2016-12-31 03:03:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606763002/40001
3 years, 11 months ago (2017-01-03 08:34:30 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 11 months ago (2017-01-03 08:40:35 UTC) #23
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/e14a6ca3bed003384db8a69064fbbb9cd2a533d6 Cr-Commit-Position: refs/heads/master@{#441099}
3 years, 11 months ago (2017-01-03 08:43:15 UTC) #25
Byoungkwon Ko
3 years, 11 months ago (2017-01-03 08:53:10 UTC) #26
Message was sent while issue was closed.
https://codereview.chromium.org/2606763002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point.html
(left):

https://codereview.chromium.org/2606763002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point.html:29:
}, 'DOMPoint constructor with x parameter');
On 2016/12/31 03:03:59, zino wrote:
> Please remove this test as well.

Done.

https://codereview.chromium.org/2606763002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMPoint.idl (left):

https://codereview.chromium.org/2606763002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMPoint.idl:9: //
https://www.w3.org/Bugs/Public/show_bug.cgi?id=28108
On 2016/12/31 03:03:59, zino wrote:
> Please remove this comment as well.

Done.

Powered by Google App Engine
This is Rietveld 408576698