Add HpackDecoderTables, static and dynamic tables for decoding HPACK.

Add HpackDecoderTables, static and dynamic tables for decoding HPACK.

Also add http2/tools/random_util.{h,cc}.

This CL lands server changes 129276755 and 130241330 by jamessynge.

BUG=488484
Review-Url: https://codereview.chromium.org/2606733004
Cr-Commit-Position: refs/heads/master@{#441716}
Committed: https://chromium.googlesource.com/chromium/src/+/67be98c95963be206f8a3caef780f10f5826a93c

[Bence, 2016-12-28 00:10:20]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 00:10:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 00:14:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 00:14:31]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bence, 2016-12-28 01:21:00]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 01:21:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 02:22:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 02:22:17]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Bence, 2016-12-28 13:26:30]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 13:26:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 14:33:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 14:33:32]

Dry run: This issue passed the CQ dry run.

[Bence, 2016-12-28 14:56:41]

bnc@chromium.org changed reviewers:
+ jamessynge@chromium.org

[Bence, 2016-12-28 14:56:42]

James: PTAL.  Thank you.

https://codereview.chromium.org/2606733004/diff/20001/net/http2/hpack/hpack_s...
File net/http2/hpack/hpack_string.h (right):

https://codereview.chromium.org/2606733004/diff/20001/net/http2/hpack/hpack_s...
net/http2/hpack/hpack_string.h:33: HpackString& operator=(const HpackString&
other) = default;
I need to explicitly define a copy assignment operator here, because in Chromium
an explicit move constructor like the one above implicitly deletes the copy
assignment operator otherwise.

https://codereview.chromium.org/2606733004/diff/20001/net/http2/hpack/hpack_s...
net/http2/hpack/hpack_string.h:67: HpackString name;
These member cannot be const: it is not possible for const HpackString to have a
copy assignment operator, and because of this, it cannot be stored in a
std::vector in Chromium.

[James Synge, 2017-01-03 19:11:29]

lgtm

https://codereview.chromium.org/2606733004/diff/40001/net/http2/hpack/hpack_s...
File net/http2/hpack/hpack_string.h (right):

https://codereview.chromium.org/2606733004/diff/40001/net/http2/hpack/hpack_s...
net/http2/hpack/hpack_string.h:33: HpackString& operator=(const HpackString&
other) = default;
Shouldn't operators come after ctor/dtor?

https://codereview.chromium.org/2606733004/diff/40001/net/http2/tools/http2_r...
File net/http2/tools/http2_random.h (right):

https://codereview.chromium.org/2606733004/diff/40001/net/http2/tools/http2_r...
net/http2/tools/http2_random.h:38: class Http2Random : public RandomBase {
Seems like there should be a comment indicating that this has no state, so each
instance shares the same underlying generator, seed and state, in
base/rand_util.

[Bence, 2017-01-04 16:15:20]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2017-01-04 16:15:21]

Ryan: PTAL.  Thanks.

https://codereview.chromium.org/2606733004/diff/40001/net/http2/hpack/hpack_s...
File net/http2/hpack/hpack_string.h (right):

https://codereview.chromium.org/2606733004/diff/40001/net/http2/hpack/hpack_s...
net/http2/hpack/hpack_string.h:33: HpackString& operator=(const HpackString&
other) = default;
On 2017/01/03 19:11:29, James Synge wrote:
> Shouldn't operators come after ctor/dtor?

Assignment operators seem to preceed the destructor:
https://google.github.io/styleguide/cppguide.html#Declaration_Order.

https://codereview.chromium.org/2606733004/diff/40001/net/http2/tools/http2_r...
File net/http2/tools/http2_random.h (right):

https://codereview.chromium.org/2606733004/diff/40001/net/http2/tools/http2_r...
net/http2/tools/http2_random.h:38: class Http2Random : public RandomBase {
On 2017/01/03 19:11:29, James Synge wrote:
> Seems like there should be a comment indicating that this has no state, so
each
> instance shares the same underlying generator, seed and state, in
> base/rand_util.

Done.

[Ryan Hamilton, 2017-01-05 15:39:54]

lgtm

[Bence, 2017-01-05 15:45:06]

Thank you.  FYI I'm waiting for https://crrev.com/2600403002 to land, then
restarting trybots here, to avoid surprises.  I've been burnt by committing
conflicting patches simultaneously too many times.

[Bence, 2017-01-05 16:50:08]

The CQ bit was checked by bnc@chromium.org

[Bence, 2017-01-05 16:50:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamessynge@chromium.org, rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2606733004/#ps80001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-01-05 16:50:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 18:52:02]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1483635008659090,
"parent_rev": "826b507a7c29ed99f7389256ec19bfc5354acb77", "commit_rev":
"67be98c95963be206f8a3caef780f10f5826a93c"}

[commit-bot: I haz the power, 2017-01-05 18:52:43]

Description was changed from

==========
Add HpackDecoderTables, static and dynamic tables for decoding HPACK.

Also add http2/tools/random_util.{h,cc}.

This CL lands server changes 129276755 and 130241330 by jamessynge.

BUG=488484
==========

to

==========
Add HpackDecoderTables, static and dynamic tables for decoding HPACK.

Also add http2/tools/random_util.{h,cc}.

This CL lands server changes 129276755 and 130241330 by jamessynge.

BUG=488484

Review-Url: https://codereview.chromium.org/2606733004
Cr-Commit-Position: refs/heads/master@{#441716}
Committed:
https://chromium.googlesource.com/chromium/src/+/67be98c95963be206f8a3caef780...
==========

[commit-bot: I haz the power, 2017-01-05 18:52:45]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/67be98c95963be206f8a3caef780...