[stubs] Port FastNewObjectStub to TF

[stubs] Port FastNewObjectStub to TF

In the process, convert from a code stub into a builtin.

Review-Url: https://codereview.chromium.org/2606733002
Cr-Commit-Position: refs/heads/master@{#41986}
Committed: https://chromium.googlesource.com/v8/v8/+/5b02a98bfada37eafe94373e3fed1e11318d9a27

[danno, 2016-12-28 10:14:20]

danno@chromium.org changed reviewers:
+ epertoso@chromium.org

[danno, 2016-12-28 17:55:48]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 17:55:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 17:58:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 17:58:46]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/18377)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/14822)

[danno, 2016-12-28 18:04:35]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 18:04:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 18:35:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 18:35:37]

Dry run: This issue passed the CQ dry run.

[danno, 2016-12-29 08:35:59]

Description was changed from

==========
[stubs] Port FastNewObjectStub to TF
==========

to

==========
[stubs] Port FastNewObjectStub to TF

In the process, convert from a code stub into a builtin.
==========

[danno, 2016-12-29 08:36:00]

danno@chromium.org changed reviewers:
+ ishell@chromium.org, mvstanton@chromium.org
- epertoso@chromium.org

[danno, 2016-12-29 08:36:10]

PTAL

[mvstanton, 2016-12-29 10:19:00]

LGTM!

https://codereview.chromium.org/2606733002/diff/140001/src/builtins/ia32/buil...
File src/builtins/ia32/builtins-ia32.cc (left):

https://codereview.chromium.org/2606733002/diff/140001/src/builtins/ia32/buil...
src/builtins/ia32/builtins-ia32.cc:138: FastNewObjectStub stub(masm->isolate());
A small thing: but CodeFactory::FastNewObject(isolate); will insulate this code
against any future changes.

[mvstanton, 2016-12-29 10:24:33]

small extra note...

https://codereview.chromium.org/2606733002/diff/140001/src/builtins/builtins-...
File src/builtins/builtins-internal.cc (right):

https://codereview.chromium.org/2606733002/diff/140001/src/builtins/builtins-...
src/builtins/builtins-internal.cc:312: void
Builtins::Generate_FastNewObject(compiler::CodeAssemblerState* state) {
TF_BUILTIN is a nice helper if you like.

[danno, 2016-12-29 10:34:20]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 10:34:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 11:01:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 11:01:55]

Dry run: This issue passed the CQ dry run.

[danno, 2016-12-29 11:09:24]

The CQ bit was checked by danno@chromium.org

[danno, 2016-12-29 11:09:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/2606733002/#ps160001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-12-29 11:09:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 11:11:15]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1483009764973110,
"parent_rev": "21ebbd3ec257a1c87da08cfd89cf5f418c9f2587", "commit_rev":
"5b02a98bfada37eafe94373e3fed1e11318d9a27"}

[commit-bot: I haz the power, 2016-12-29 11:11:21]

Description was changed from

==========
[stubs] Port FastNewObjectStub to TF

In the process, convert from a code stub into a builtin.
==========

to

==========
[stubs] Port FastNewObjectStub to TF

In the process, convert from a code stub into a builtin.

Review-Url: https://codereview.chromium.org/2606733002
Cr-Commit-Position: refs/heads/master@{#41986}
Committed:
https://chromium.googlesource.com/v8/v8/+/5b02a98bfada37eafe94373e3fed1e11318...
==========

[commit-bot: I haz the power, 2016-12-29 11:11:22]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/v8/v8/+/5b02a98bfada37eafe94373e3fed1e11318...