Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 260673003: Revert of Use DiscardableMemoryManager on Android. (Closed)

Created:
6 years, 7 months ago by Nikita (slow)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Visibility:
Public.

Description

Revert of Use DiscardableMemoryManager on Android. (https://codereview.chromium.org/195863005/) Reason for revert: Fails compile http://goo.gl/qePAC4 Original issue's description: > Use DiscardableMemoryManager on Android. > > This allows userspace (DiscardableMemoryManager) to control eviction of > unlocked DiscardableMemory instances to prevent the process from running out of > address space in cases of heavy use of unlocked DiscardableMemory. > > This also removes all the occurences of 'Android' from the ashmem allocator to > allow it to be later used on ChromeOS. > > BUG=327516, 334996 > R=reveman@chromium.org, willchan@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267170

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+984 lines, -1126 lines) Patch
M base/base.gyp View 2 chunks +1 line, -5 lines 0 comments Download
M base/base.gypi View 2 chunks +2 lines, -8 lines 0 comments Download
M base/memory/discardable_memory.h View 2 chunks +5 lines, -1 line 0 comments Download
M base/memory/discardable_memory.cc View 1 chunk +1 line, -1 line 0 comments Download
A base/memory/discardable_memory_allocator_android.h View 1 chunk +70 lines, -0 lines 0 comments Download
A base/memory/discardable_memory_allocator_android.cc View 1 chunk +553 lines, -0 lines 0 comments Download
A base/memory/discardable_memory_allocator_android_unittest.cc View 1 chunk +303 lines, -0 lines 0 comments Download
M base/memory/discardable_memory_android.cc View 5 chunks +16 lines, -26 lines 0 comments Download
D base/memory/discardable_memory_ashmem.h View 1 chunk +0 lines, -55 lines 0 comments Download
D base/memory/discardable_memory_ashmem.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D base/memory/discardable_memory_ashmem_allocator.h View 1 chunk +0 lines, -93 lines 0 comments Download
D base/memory/discardable_memory_ashmem_allocator.cc View 1 chunk +0 lines, -527 lines 0 comments Download
D base/memory/discardable_memory_ashmem_allocator_unittest.cc View 1 chunk +0 lines, -319 lines 0 comments Download
M base/memory/discardable_memory_emulated.h View 2 chunks +2 lines, -3 lines 0 comments Download
M base/memory/discardable_memory_emulated.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M base/memory/discardable_memory_linux.cc View 2 chunks +6 lines, -1 line 0 comments Download
M base/memory/discardable_memory_mac.cc View 2 chunks +6 lines, -1 line 0 comments Download
M base/memory/discardable_memory_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/discardable_memory_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/discardable_memory_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/discardable_memory_unittest.cc View 3 chunks +5 lines, -1 line 0 comments Download
M base/memory/discardable_memory_win.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Nikita (slow)
Created Revert of Use DiscardableMemoryManager on Android.
6 years, 7 months ago (2014-04-30 11:08:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/260673003/1
6 years, 7 months ago (2014-04-30 11:08:47 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 11:08:48 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-04-30 11:08:48 UTC) #4
Nikita (slow)
The CQ bit was unchecked by nkostylev@chromium.org
6 years, 7 months ago (2014-04-30 11:08:48 UTC) #5
Nikita (slow)
6 years, 7 months ago (2014-04-30 11:09:11 UTC) #6
Already reverted at https://codereview.chromium.org/264633002/

Closing.

Powered by Google App Engine
This is Rietveld 408576698