Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2606703003: Remove PasswordFormManager::presaved_form_ (Closed)

Created:
3 years, 12 months ago by vabr (Chromium)
Modified:
3 years, 11 months ago
Reviewers:
dvadym
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PasswordFormManager::presaved_form_ Just a clean-up. Spotted an unused data member when looking at PasswordFormManager, so this CL removes it. BUG=621355 Committed: https://crrev.com/aa0a47da3bea6e5455edb113f1f5682fbe34eb27 Cr-Commit-Position: refs/heads/master@{#440749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M components/password_manager/core/browser/password_form_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
vabr (Chromium)
Hi Vadym, Could you please review this CL? Thanks, Vaclav
3 years, 12 months ago (2016-12-27 10:52:56 UTC) #6
dvadym
LGTM
3 years, 12 months ago (2016-12-27 11:41:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606703003/1
3 years, 12 months ago (2016-12-27 11:53:02 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-27 11:56:28 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:46:04 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa0a47da3bea6e5455edb113f1f5682fbe34eb27
Cr-Commit-Position: refs/heads/master@{#440749}

Powered by Google App Engine
This is Rietveld 408576698