Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2606563002:
Remove base::ScopedPtrHashMap from chrome/browser/media_galleries/. (Closed)
|
Created:
3 years, 12 months ago by Avi (use Gerrit) Modified:
3 years, 11 months ago CC:
chromium-reviews, Lei Zhang, tommycli, oshima+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove base::ScopedPtrHashMap from chrome/browser/media_galleries/.
BUG=579229
Committed: https://crrev.com/3e92506121665932c512fbbd3f19e61a328d2fe2
Cr-Commit-Position: refs/heads/master@{#440798}
Patch Set 1 #
Total comments: 8
Patch Set 2 : rev #Messages
Total messages: 20 (13 generated)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
avi@chromium.org changed reviewers: + reillyg@chromium.org, thestig@chromium.org, tommycli@chromium.org
To anyone who's around this time of year.
https://codereview.chromium.org/2606563002/diff/1/chrome/browser/media_galler... File chrome/browser/media_galleries/chromeos/mtp_device_delegate_impl_chromeos.cc (right): https://codereview.chromium.org/2606563002/diff/1/chrome/browser/media_galler... chrome/browser/media_galleries/chromeos/mtp_device_delegate_impl_chromeos.cc:460: base::WrapUnique(new MTPFileNode(id, name, this, file_id_to_node_map_)); base::MakeUnique<MTPFileNode>(id, name, this, file_id_to_node_map_); https://codereview.chromium.org/2606563002/diff/1/chrome/browser/media_galler... chrome/browser/media_galleries/chromeos/mtp_device_delegate_impl_chromeos.cc:466: std::set<std::string> children_to_erase; This should be a vector instead of a set. https://codereview.chromium.org/2606563002/diff/1/chrome/browser/media_galler... chrome/browser/media_galleries/chromeos/mtp_device_delegate_impl_chromeos.cc:471: } for (const auto& it : children_) { if (base::ContainsKey(children_to_key, it.first) continue; children_to_erase.insert(it.first) } https://codereview.chromium.org/2606563002/diff/1/chrome/browser/media_galler... chrome/browser/media_galleries/chromeos/mtp_device_delegate_impl_chromeos.cc:475: } for (const auto& child : children_to_erase) children_.erase(child);
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
done; ptal https://codereview.chromium.org/2606563002/diff/1/chrome/browser/media_galler... File chrome/browser/media_galleries/chromeos/mtp_device_delegate_impl_chromeos.cc (right): https://codereview.chromium.org/2606563002/diff/1/chrome/browser/media_galler... chrome/browser/media_galleries/chromeos/mtp_device_delegate_impl_chromeos.cc:460: base::WrapUnique(new MTPFileNode(id, name, this, file_id_to_node_map_)); On 2016/12/27 16:26:17, Reilly Grant wrote: > base::MakeUnique<MTPFileNode>(id, name, this, file_id_to_node_map_); Done. https://codereview.chromium.org/2606563002/diff/1/chrome/browser/media_galler... chrome/browser/media_galleries/chromeos/mtp_device_delegate_impl_chromeos.cc:466: std::set<std::string> children_to_erase; On 2016/12/27 16:26:17, Reilly Grant wrote: > This should be a vector instead of a set. Done. https://codereview.chromium.org/2606563002/diff/1/chrome/browser/media_galler... chrome/browser/media_galleries/chromeos/mtp_device_delegate_impl_chromeos.cc:471: } On 2016/12/27 16:26:17, Reilly Grant wrote: > for (const auto& it : children_) { > if (base::ContainsKey(children_to_key, it.first) > continue; > children_to_erase.insert(it.first) > } push_back. Done. https://codereview.chromium.org/2606563002/diff/1/chrome/browser/media_galler... chrome/browser/media_galleries/chromeos/mtp_device_delegate_impl_chromeos.cc:475: } On 2016/12/27 16:26:17, Reilly Grant wrote: > for (const auto& child : children_to_erase) > children_.erase(child); Done.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by avi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482877646565090,
"parent_rev": "e9255da8ed217094d6c4479c134270502c9bb238", "commit_rev":
"41254ebe5adbcb4f62ecdce3977f94e1c20ac2a3"}
Message was sent while issue was closed.
Description was changed from ========== Remove base::ScopedPtrHashMap from chrome/browser/media_galleries/. BUG=579229 ========== to ========== Remove base::ScopedPtrHashMap from chrome/browser/media_galleries/. BUG=579229 Review-Url: https://codereview.chromium.org/2606563002 Committed: https://chromium.googlesource.com/chromium/src/+/41254ebe5adbcb4f62ecdce3977f... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/41254ebe5adbcb4f62ecdce3977f...
Message was sent while issue was closed.
Description was changed from ========== Remove base::ScopedPtrHashMap from chrome/browser/media_galleries/. BUG=579229 Review-Url: https://codereview.chromium.org/2606563002 Committed: https://chromium.googlesource.com/chromium/src/+/41254ebe5adbcb4f62ecdce3977f... ========== to ========== Remove base::ScopedPtrHashMap from chrome/browser/media_galleries/. BUG=579229 Committed: https://crrev.com/3e92506121665932c512fbbd3f19e61a328d2fe2 Cr-Commit-Position: refs/heads/master@{#440798} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3e92506121665932c512fbbd3f19e61a328d2fe2 Cr-Commit-Position: refs/heads/master@{#440798} |
