Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2606383005: [turbofan] Teach escape analysis about StringCharAt (Closed)

Created:
3 years, 11 months ago by Tobias Tebbi
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Teach escape analysis about StringCharAt R=bmeurer@chromium.org BUG=chromium:677757 Review-Url: https://codereview.chromium.org/2606383005 Cr-Commit-Position: refs/heads/master@{#42066} Committed: https://chromium.googlesource.com/v8/v8/+/5662f99b998a786ece73586375776ff15423d230

Patch Set 1 #

Patch Set 2 : corrected year #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/compiler/escape-analysis.cc View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-677757.js View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Tobias Tebbi
3 years, 11 months ago (2017-01-04 11:31:24 UTC) #1
Jarin
lgtm
3 years, 11 months ago (2017-01-04 11:33:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606383005/20001
3 years, 11 months ago (2017-01-04 11:37:03 UTC) #5
Benedikt Meurer
LGTM.
3 years, 11 months ago (2017-01-04 11:50:27 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 12:01:44 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/5662f99b998a786ece73586375776ff1542...

Powered by Google App Engine
This is Rietveld 408576698