Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 2606363002: [MediaNotification] Fix logic for resetting MediaImage (Closed)

Created:
3 years, 11 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 11 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MediaNotification] Fix logic for resetting MediaImage This CL fixes the logic for unsetting MediaImage in the notification in the following two cases: * When image download returns 404. * When setting null metadata. BUG=676997 R=mlamouri@chromium.org Review-Url: https://codereview.chromium.org/2606363002 Cr-Commit-Position: refs/heads/master@{#441636} Committed: https://chromium.googlesource.com/chromium/src/+/994960d632298a60bb6974a3b0a0217023eef4f0

Patch Set 1 #

Patch Set 2 : added unit tests #

Patch Set 3 : fixed build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -17 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java View 1 8 chunks +17 lines, -13 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaImageManagerTest.java View 1 2 1 chunk +208 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
Zhiqiang Zhang (Slow)
3 years, 11 months ago (2017-01-03 14:17:24 UTC) #2
mlamouri (slow - plz ping)
lgtm but any chance we can get some tests? maybe java unit tests could work? ...
3 years, 11 months ago (2017-01-04 15:59:03 UTC) #6
Zhiqiang Zhang (Slow)
PTAL the tests :)
3 years, 11 months ago (2017-01-04 18:11:16 UTC) #7
mlamouri (slow - plz ping)
lgtm lgtm 👍 \o/
3 years, 11 months ago (2017-01-05 12:14:25 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606363002/40001
3 years, 11 months ago (2017-01-05 12:14:44 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 12:48:30 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/994960d632298a60bb6974a3b0a0...

Powered by Google App Engine
This is Rietveld 408576698