Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2606353004: Fix iOS omnibox append button highlighted icon for RTL (Closed)

Created:
3 years, 11 months ago by mattreynolds
Modified:
3 years, 11 months ago
CC:
chromium-reviews, jdonnelly+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix iOS omnibox append button highlighted icon for RTL The omnibox append button's normal (un-highlighted) image is correctly reversed for RTL languages, but the imaged displayed when the button is tapped is not. BUG=678085 Committed: https://crrev.com/6613efc1e1e34ef8da08158330112926c6afd3b8 Cr-Commit-Position: refs/heads/master@{#441418}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
mattreynolds
Hi Mark, PTAL
3 years, 11 months ago (2017-01-03 22:33:27 UTC) #2
noyau (Ping after 24h)
lgtm
3 years, 11 months ago (2017-01-04 10:34:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606353004/1
3 years, 11 months ago (2017-01-04 18:33:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 18:44:37 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 18:47:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6613efc1e1e34ef8da08158330112926c6afd3b8
Cr-Commit-Position: refs/heads/master@{#441418}

Powered by Google App Engine
This is Rietveld 408576698