Enable the new analysis driver by default, use --disable-new-analysis-driver to disable.

Enable the new analysis driver by default, use --disable-new-analysis-driver to disable.

R=paulberry@google.com, brianwilkerson@google.com, devoncarew@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/7e560a612f7e66fd5986c4a663618e45b95f8060

[Paul Berry, 2017-01-03 18:00:05]

lgtm, assuming nothing comes up in our meeting this afternoon.

[Brian Wilkerson, 2017-01-03 18:00:12]

While this looks like the right way to implement the change, I'd like to have
the conversation scheduled for this afternoon before this gets committed (so you
can convince me that it won't negatively impact any clients).

[devoncarew, 2017-01-03 19:40:59]

https://codereview.chromium.org/2606283005/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/server/driver.dart (right):

https://codereview.chromium.org/2606283005/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/server/driver.dart:248:
'disable-new-analysis-driver';
Does the analysis server ignore arguments is doesn't understand? Some few
clients will be passing in --enable-new-analysis-driver.

[scheglov, 2017-01-03 19:42:33]

On 2017/01/03 19:40:59, devoncarew wrote:
>
https://codereview.chromium.org/2606283005/diff/1/pkg/analysis_server/lib/src...
> File pkg/analysis_server/lib/src/server/driver.dart (right):
> 
>
https://codereview.chromium.org/2606283005/diff/1/pkg/analysis_server/lib/src...
> pkg/analysis_server/lib/src/server/driver.dart:248:
> 'disable-new-analysis-driver';
> Does the analysis server ignore arguments is doesn't understand? Some few
> clients will be passing in --enable-new-analysis-driver.

Yes, the server ignores unknown arguments.

[scheglov, 2017-01-03 22:50:21]

Description was changed from

==========
Enable the new analysis driver by default, use --disable-new-analysis-driver to
disable.

R=brianwilkerson@google.com, paulberry@google.com, devoncarew@google.com
BUG=
==========

to

==========
Enable the new analysis driver by default, use --disable-new-analysis-driver to
disable.

R=paulberry@google.com, brianwilkerson@google.com, devoncarew@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/7e560a612f7e66fd5986c4a663618e45b95f8060
==========

[scheglov, 2017-01-03 22:50:23]

Committed patchset #1 (id:1) manually as
7e560a612f7e66fd5986c4a663618e45b95f8060 (presubmit successful).