Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Side by Side Diff: pkg/analysis_server/lib/src/server/driver.dart

Issue 2606283005: Enable the new analysis driver by default, use --disable-new-analysis-driver to disable. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/integration/integration_tests.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library driver; 5 library driver;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:io'; 8 import 'dart:io';
9 import 'dart:math'; 9 import 'dart:math';
10 10
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 static const String INCREMENTAL_RESOLUTION_LOG = "incremental-resolution-log"; 235 static const String INCREMENTAL_RESOLUTION_LOG = "incremental-resolution-log";
236 236
237 /** 237 /**
238 * The name of the option used to enable validation of incremental resolution 238 * The name of the option used to enable validation of incremental resolution
239 * results. 239 * results.
240 */ 240 */
241 static const String INCREMENTAL_RESOLUTION_VALIDATION = 241 static const String INCREMENTAL_RESOLUTION_VALIDATION =
242 "incremental-resolution-validation"; 242 "incremental-resolution-validation";
243 243
244 /** 244 /**
245 * The name of the option used to enable using the new analysis driver. 245 * The name of the option used to disable using the new analysis driver.
246 */ 246 */
247 static const String ENABLE_NEW_ANALYSIS_DRIVER = 'enable-new-analysis-driver'; 247 static const String DISABLE_NEW_ANALYSIS_DRIVER =
248 'disable-new-analysis-driver';
devoncarew 2017/01/03 19:40:59 Does the analysis server ignore arguments is doesn
248 249
249 /** 250 /**
250 * The name of the option used to enable using pub summary manager. 251 * The name of the option used to enable using pub summary manager.
251 */ 252 */
252 static const String ENABLE_PUB_SUMMARY_MANAGER = 'enable-pub-summary-manager'; 253 static const String ENABLE_PUB_SUMMARY_MANAGER = 'enable-pub-summary-manager';
253 254
254 /** 255 /**
255 * The name of the option used to enable fined grained invalidation. 256 * The name of the option used to enable fined grained invalidation.
256 */ 257 */
257 static const String FINER_GRAINED_INVALIDATION = 'finer-grained-invalidation'; 258 static const String FINER_GRAINED_INVALIDATION = 'finer-grained-invalidation';
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
386 return; 387 return;
387 } 388 }
388 } 389 }
389 390
390 AnalysisServerOptions analysisServerOptions = new AnalysisServerOptions(); 391 AnalysisServerOptions analysisServerOptions = new AnalysisServerOptions();
391 analysisServerOptions.enableIncrementalResolutionApi = 392 analysisServerOptions.enableIncrementalResolutionApi =
392 results[ENABLE_INCREMENTAL_RESOLUTION_API]; 393 results[ENABLE_INCREMENTAL_RESOLUTION_API];
393 analysisServerOptions.enableIncrementalResolutionValidation = 394 analysisServerOptions.enableIncrementalResolutionValidation =
394 results[INCREMENTAL_RESOLUTION_VALIDATION]; 395 results[INCREMENTAL_RESOLUTION_VALIDATION];
395 analysisServerOptions.enableNewAnalysisDriver = 396 analysisServerOptions.enableNewAnalysisDriver =
396 results[ENABLE_NEW_ANALYSIS_DRIVER]; 397 !results[DISABLE_NEW_ANALYSIS_DRIVER];
397 analysisServerOptions.enablePubSummaryManager = 398 analysisServerOptions.enablePubSummaryManager =
398 results[ENABLE_PUB_SUMMARY_MANAGER]; 399 results[ENABLE_PUB_SUMMARY_MANAGER];
399 analysisServerOptions.finerGrainedInvalidation = 400 analysisServerOptions.finerGrainedInvalidation =
400 results[FINER_GRAINED_INVALIDATION]; 401 results[FINER_GRAINED_INVALIDATION];
401 analysisServerOptions.noErrorNotification = results[NO_ERROR_NOTIFICATION]; 402 analysisServerOptions.noErrorNotification = results[NO_ERROR_NOTIFICATION];
402 analysisServerOptions.noIndex = results[NO_INDEX]; 403 analysisServerOptions.noIndex = results[NO_INDEX];
403 analysisServerOptions.useAnalysisHighlight2 = 404 analysisServerOptions.useAnalysisHighlight2 =
404 results[USE_ANALISYS_HIGHLIGHT2]; 405 results[USE_ANALISYS_HIGHLIGHT2];
405 analysisServerOptions.fileReadMode = results[FILE_READ_MODE]; 406 analysisServerOptions.fileReadMode = results[FILE_READ_MODE];
406 analysisServerOptions.newAnalysisDriverLog = 407 analysisServerOptions.newAnalysisDriverLog =
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
536 parser.addFlag(HELP_OPTION, 537 parser.addFlag(HELP_OPTION,
537 help: "print this help message without starting a server", 538 help: "print this help message without starting a server",
538 defaultsTo: false, 539 defaultsTo: false,
539 negatable: false); 540 negatable: false);
540 parser.addOption(INCREMENTAL_RESOLUTION_LOG, 541 parser.addOption(INCREMENTAL_RESOLUTION_LOG,
541 help: "set a destination for the incremental resolver's log"); 542 help: "set a destination for the incremental resolver's log");
542 parser.addFlag(INCREMENTAL_RESOLUTION_VALIDATION, 543 parser.addFlag(INCREMENTAL_RESOLUTION_VALIDATION,
543 help: "enable validation of incremental resolution results (slow)", 544 help: "enable validation of incremental resolution results (slow)",
544 defaultsTo: false, 545 defaultsTo: false,
545 negatable: false); 546 negatable: false);
546 parser.addFlag(ENABLE_NEW_ANALYSIS_DRIVER, 547 parser.addFlag(DISABLE_NEW_ANALYSIS_DRIVER,
547 help: "enable using new analysis driver", 548 help: "disable using new analysis driver",
548 defaultsTo: false, 549 defaultsTo: false,
549 negatable: false); 550 negatable: false);
550 parser.addFlag(ENABLE_PUB_SUMMARY_MANAGER, 551 parser.addFlag(ENABLE_PUB_SUMMARY_MANAGER,
551 help: "enable using summaries for pub cache packages", 552 help: "enable using summaries for pub cache packages",
552 defaultsTo: false, 553 defaultsTo: false,
553 negatable: false); 554 negatable: false);
554 parser.addFlag(FINER_GRAINED_INVALIDATION, 555 parser.addFlag(FINER_GRAINED_INVALIDATION,
555 help: "enable finer grained invalidation", 556 help: "enable finer grained invalidation",
556 defaultsTo: false, 557 defaultsTo: false,
557 negatable: false); 558 negatable: false);
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
654 */ 655 */
655 static void _rollLogFiles(String path, int numOld) { 656 static void _rollLogFiles(String path, int numOld) {
656 for (int i = numOld - 1; i >= 0; i--) { 657 for (int i = numOld - 1; i >= 0; i--) {
657 try { 658 try {
658 String oldPath = i == 0 ? path : '$path.$i'; 659 String oldPath = i == 0 ? path : '$path.$i';
659 new File(oldPath).renameSync('$path.${i+1}'); 660 new File(oldPath).renameSync('$path.${i+1}');
660 } catch (e) {} 661 } catch (e) {}
661 } 662 }
662 } 663 }
663 } 664 }
OLDNEW
« no previous file with comments | « no previous file | pkg/analysis_server/test/integration/integration_tests.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698