Chromium Code Reviews
DescriptionRevert of Disable tracking of visits to bookmarks in incognito (patchset #1 id:1 of https://codereview.chromium.org/2603213002/ )
Reason for revert:
bookmark_last_visit_updater_unittest.cc does not compile on the M56 branch.
Signature of one function that I use in the unit-test is different from the one on trunk, I need to fix it.
Original issue's description:
> Disable tracking of visits to bookmarks in incognito
>
> Date of the last visit to any bookmarked page is stored to
> BookmarkModel. Previously, this happens in off-the-record profiles as
> well. This CL fixes the issue.
>
> BUG=662382
>
> Had to manually resolve (trivial) conflicts within drover when merging to M56, so I add TBR.
>
> TBR=avi@chromium.org,bauerb@chromium.org,battre@chromium.org
>
> Review-Url: https://codereview.chromium.org/2572433002
> Cr-Commit-Position: refs/heads/master@{#438845}
> (cherry picked from commit 1e385fa1c19d96f343594a0623a7985adb50c483)
>
> Committed: https://chromium.googlesource.com/chromium/src/+/62f09cadded58c144c804dfacf0ef7305247ad90
TBR=avi@chromium.org,bauerb@chromium.org,battre@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=662382
Review-Url: https://codereview.chromium.org/2606283003
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||