Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2606283003: Revert of Disable tracking of visits to bookmarks in incognito (Closed)

Created:
3 years, 11 months ago by jkrcal
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Revert of Disable tracking of visits to bookmarks in incognito (patchset #1 id:1 of https://codereview.chromium.org/2603213002/ ) Reason for revert: bookmark_last_visit_updater_unittest.cc does not compile on the M56 branch. Signature of one function that I use in the unit-test is different from the one on trunk, I need to fix it. Original issue's description: > Disable tracking of visits to bookmarks in incognito > > Date of the last visit to any bookmarked page is stored to > BookmarkModel. Previously, this happens in off-the-record profiles as > well. This CL fixes the issue. > > BUG=662382 > > Had to manually resolve (trivial) conflicts within drover when merging to M56, so I add TBR. > > TBR=avi@chromium.org,bauerb@chromium.org,battre@chromium.org > > Review-Url: https://codereview.chromium.org/2572433002 > Cr-Commit-Position: refs/heads/master@{#438845} > (cherry picked from commit 1e385fa1c19d96f343594a0623a7985adb50c483) > > Committed: https://chromium.googlesource.com/chromium/src/+/62f09cadded58c144c804dfacf0ef7305247ad90 TBR=avi@chromium.org,bauerb@chromium.org,battre@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=662382 Review-Url: https://codereview.chromium.org/2606283003

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -118 lines) Patch
M chrome/browser/ntp_snippets/bookmark_last_visit_updater.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ntp_snippets/bookmark_last_visit_updater.cc View 4 chunks +11 lines, -11 lines 0 comments Download
D chrome/browser/ntp_snippets/bookmark_last_visit_updater_unittest.cc View 1 chunk +0 lines, -104 lines 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
jkrcal
Created Revert of Disable tracking of visits to bookmarks in incognito
3 years, 11 months ago (2017-01-03 09:19:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606283003/1
3 years, 11 months ago (2017-01-03 09:19:22 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 09:24:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698