[Turbofan] Run escape analysis concurrently.

[Turbofan] Run escape analysis concurrently.

BUG=v8:5428
Review-Url: https://codereview.chromium.org/2606273002
Cr-Commit-Position: refs/heads/master@{#42027}
Committed: https://chromium.googlesource.com/v8/v8/+/35a393f87a962f8fe0952060120034b312310d59

[mvstanton, 2017-01-03 09:56:40]

mvstanton@chromium.org changed reviewers:
+ jarin@chromium.org

[mvstanton, 2017-01-03 09:56:40]

Hi Jaro, PTAL, thanks!
--Michael

[mvstanton, 2017-01-03 10:12:57]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 10:13:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 10:26:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 10:26:32]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Jarin, 2017-01-03 10:39:05]

lgtm, but bots do not agree.

I am afraid this is not really your fault, but simplified lowering's fault - it
cannot handle TypeGuards all that well (https://crbug.com/675704).

https://codereview.chromium.org/2606273002/diff/40001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/2606273002/diff/40001/src/compiler/pipeline.c...
src/compiler/pipeline.cc:992: struct OptimizationPrepPhase {
Naming nit: maybe something that captures the concurrent aspect of this?
Something like ConcurrentOptimizationPrepPhase or ConcurrentRunPrepPhase?

[mvstanton, 2017-01-03 12:33:40]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 12:33:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 12:57:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 12:58:00]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2017-01-03 12:58:59]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2017-01-03 12:58:59]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2606273002/#ps60001
(title: "Benedikt's solution for phis.")

[commit-bot: I haz the power, 2017-01-03 12:59:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2017-01-03 13:00:53]

Thanks Jaro, Benedikts solution for creating phis did a better job, avoided
running into that bug you mentioned. A "joint effort" :p.
--michael

https://codereview.chromium.org/2606273002/diff/40001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/2606273002/diff/40001/src/compiler/pipeline.c...
src/compiler/pipeline.cc:992: struct OptimizationPrepPhase {
On 2017/01/03 10:39:05, Jarin wrote:
> Naming nit: maybe something that captures the concurrent aspect of this?
> Something like ConcurrentOptimizationPrepPhase or ConcurrentRunPrepPhase?

Thanks, good idea!

[commit-bot: I haz the power, 2017-01-03 13:01:37]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483448339356670,
"parent_rev": "b0e9116d59326a4f9a4f4691b61a510e342338c9", "commit_rev":
"35a393f87a962f8fe0952060120034b312310d59"}

[commit-bot: I haz the power, 2017-01-03 13:01:42]

Description was changed from

==========
[Turbofan] Run escape analysis concurrently.

BUG=v8:5428
==========

to

==========
[Turbofan] Run escape analysis concurrently.

BUG=v8:5428

Review-Url: https://codereview.chromium.org/2606273002
Cr-Commit-Position: refs/heads/master@{#42027}
Committed:
https://chromium.googlesource.com/v8/v8/+/35a393f87a962f8fe0952060120034b3123...
==========

[commit-bot: I haz the power, 2017-01-03 13:01:43]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/35a393f87a962f8fe0952060120034b3123...