content/common/view_messages.h - Issue 260623004: Fix to remove customised String over IPC for SmartClip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/view_messages.h

Issue 260623004: Fix to remove customised String over IPC for SmartClip (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes done according to review comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_android.cc ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/view_messages.h

diff --git a/content/common/view_messages.h b/content/common/view_messages.h

index e713f05bae2b46cef639aaa8f29444c7cfce3d2f..bd1084dfaf21038d8b33ec9d4fa79cb7ef0188a7 100644

--- a/content/common/view_messages.h

+++ b/content/common/view_messages.h

@@ -1730,11 +1730,9 @@ IPC_MESSAGE_ROUTED1(ViewHostMsg_SetNeedsBeginFrame,

bool /* enabled */)

// Reply to the ViewMsg_ExtractSmartClipData message.

-// TODO(juhui24.lee@samsung.com): this should be changed to a vector of structs

-// instead of encoding the data as a string which is not allowed normally. Since

-// ths is only used in Android WebView, it's allowed temporarily.

-// http://crbug.com/330872

-IPC_MESSAGE_ROUTED1(ViewHostMsg_SmartClipDataExtracted, base::string16)

+IPC_MESSAGE_ROUTED2(ViewHostMsg_SmartClipDataExtracted,

+ base::string16 /* data in the clip_rect */,

+ gfx::Rect /* Clip rect bounds */)

jam 2014/05/05 15:07:32 by convention, the comment for an IPC parameter ma

#elif defined(OS_MACOSX)

// Request that the browser load a font into shared memory for us.