Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Side by Side Diff: content/common/view_messages.h

Issue 260623004: Fix to remove customised String over IPC for SmartClip (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes done according to review comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // IPC messages for page rendering. 5 // IPC messages for page rendering.
6 // Multiply-included message file, hence no include guard. 6 // Multiply-included message file, hence no include guard.
7 7
8 #include "base/memory/shared_memory.h" 8 #include "base/memory/shared_memory.h"
9 #include "base/process/process.h" 9 #include "base/process/process.h"
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
(...skipping 1712 matching lines...) Expand 10 before | Expand all | Expand 10 after
1723 base::FileDescriptor /* pcm_output */, 1723 base::FileDescriptor /* pcm_output */,
1724 uint32_t /* data_size*/) 1724 uint32_t /* data_size*/)
1725 1725
1726 // Sent by renderer to request a ViewMsg_BeginFrame message for upcoming 1726 // Sent by renderer to request a ViewMsg_BeginFrame message for upcoming
1727 // display events. If |enabled| is true, the BeginFrame message will continue 1727 // display events. If |enabled| is true, the BeginFrame message will continue
1728 // to be be delivered until the notification is disabled. 1728 // to be be delivered until the notification is disabled.
1729 IPC_MESSAGE_ROUTED1(ViewHostMsg_SetNeedsBeginFrame, 1729 IPC_MESSAGE_ROUTED1(ViewHostMsg_SetNeedsBeginFrame,
1730 bool /* enabled */) 1730 bool /* enabled */)
1731 1731
1732 // Reply to the ViewMsg_ExtractSmartClipData message. 1732 // Reply to the ViewMsg_ExtractSmartClipData message.
1733 // TODO(juhui24.lee@samsung.com): this should be changed to a vector of structs 1733 IPC_MESSAGE_ROUTED2(ViewHostMsg_SmartClipDataExtracted,
1734 // instead of encoding the data as a string which is not allowed normally. Since 1734 base::string16 /* data in the clip_rect */,
1735 // ths is only used in Android WebView, it's allowed temporarily. 1735 gfx::Rect /* Clip rect bounds */)
jam 2014/05/05 15:07:32 by convention, the comment for an IPC parameter ma
1736 // http://crbug.com/330872
1737 IPC_MESSAGE_ROUTED1(ViewHostMsg_SmartClipDataExtracted, base::string16)
1738 1736
1739 #elif defined(OS_MACOSX) 1737 #elif defined(OS_MACOSX)
1740 // Request that the browser load a font into shared memory for us. 1738 // Request that the browser load a font into shared memory for us.
1741 IPC_SYNC_MESSAGE_CONTROL1_3(ViewHostMsg_LoadFont, 1739 IPC_SYNC_MESSAGE_CONTROL1_3(ViewHostMsg_LoadFont,
1742 FontDescriptor /* font to load */, 1740 FontDescriptor /* font to load */,
1743 uint32 /* buffer size */, 1741 uint32 /* buffer size */,
1744 base::SharedMemoryHandle /* font data */, 1742 base::SharedMemoryHandle /* font data */,
1745 uint32 /* font id */) 1743 uint32 /* font id */)
1746 1744
1747 // Informs the browser that a plugin has gained or lost focus. 1745 // Informs the browser that a plugin has gained or lost focus.
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
1792 // synchronously (see crbug.com/120597). This IPC message sends the character 1790 // synchronously (see crbug.com/120597). This IPC message sends the character
1793 // bounds after every composition change to always have correct bound info. 1791 // bounds after every composition change to always have correct bound info.
1794 IPC_MESSAGE_ROUTED2(ViewHostMsg_ImeCompositionRangeChanged, 1792 IPC_MESSAGE_ROUTED2(ViewHostMsg_ImeCompositionRangeChanged,
1795 gfx::Range /* composition range */, 1793 gfx::Range /* composition range */,
1796 std::vector<gfx::Rect> /* character bounds */) 1794 std::vector<gfx::Rect> /* character bounds */)
1797 #endif 1795 #endif
1798 1796
1799 // Adding a new message? Stick to the sort order above: first platform 1797 // Adding a new message? Stick to the sort order above: first platform
1800 // independent ViewMsg, then ifdefs for platform specific ViewMsg, then platform 1798 // independent ViewMsg, then ifdefs for platform specific ViewMsg, then platform
1801 // independent ViewHostMsg, then ifdefs for platform specific ViewHostMsg. 1799 // independent ViewHostMsg, then ifdefs for platform specific ViewHostMsg.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698