content/browser/android/content_view_core_impl.h - Issue 260623004: Fix to remove customised String over IPC for SmartClip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.h

Issue 260623004: Fix to remove customised String over IPC for SmartClip (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes done according to review comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/android/content_view_core_impl.h

diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h

index dd39522e1411f07d8977c0d472b297c194ba914f..b8bca51222fdbabf85cf7766b6295371510bd4dd 100644

--- a/content/browser/android/content_view_core_impl.h

+++ b/content/browser/android/content_view_core_impl.h

@@ -226,7 +226,8 @@ class ContentViewCoreImpl : public ContentViewCore,

// Public methods that call to Java via JNI

// --------------------------------------------------------------------------

- void OnSmartClipDataExtracted(const base::string16& result);

+ void OnSmartClipDataExtracted(const gfx::Rect& clip_rect,

+ const base::string16& result);

// Creates a popup menu with |items|.

// |multiple| defines if it should support multi-select.

« no previous file with comments | « no previous file | content/browser/android/content_view_core_impl.cc » ('j') | content/common/view_messages.h » ('J')