content/browser/android/content_view_core_impl.cc - Issue 260623004: Fix to remove customised String over IPC for SmartClip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 260623004: Fix to remove customised String over IPC for SmartClip (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes done according to review comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/content_view_core_impl.h ('k') | content/browser/renderer_host/render_widget_host_view_android.h » ('j') | content/common/view_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/content_view_core_impl.cc

diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc

index 30cdd6c86761bc4f485f4d7c5836436321c7e64b..95dc8ad78ea1f5c5d2498c5bcb7109ffa956e17b 100644

--- a/content/browser/android/content_view_core_impl.cc

+++ b/content/browser/android/content_view_core_impl.cc

@@ -1640,14 +1640,16 @@ jint ContentViewCoreImpl::GetCurrentRenderProcessId(JNIEnv* env, jobject obj) {

}

void ContentViewCoreImpl::OnSmartClipDataExtracted(

+ const gfx::Rect& clip_rect,

const base::string16& result) {

JNIEnv* env = AttachCurrentThread();

ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);

if (obj.is_null())

return;

+ ScopedJavaLocalRef<jobject> clip_rect_object(CreateJavaRect(env, clip_rect));

ScopedJavaLocalRef<jstring> jresult = ConvertUTF16ToJavaString(env, result);

Java_ContentViewCore_onSmartClipDataExtracted(

- env, obj.obj(), jresult.obj());

+ env, obj.obj(), jresult.obj(), clip_rect_object.obj());

}

void ContentViewCoreImpl::WebContentsDestroyed(WebContents* web_contents) {