Fix to remove customised String over IPC for SmartClip

Currently, the data for SmartClip is sent over IPC as a customized
string, which contains rect values and string of content within the
clip rect. Changes from Chromium side to remove custom serialization and
send it as a structure of rect and string values.

BUG=330872
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279072

[AviD, 2014-04-30 11:34:46]

PTAL

Corresponding Blink side changes: https://codereview.chromium.org/259263003/

[jam, 2014-04-30 16:05:45]

https://codereview.chromium.org/260623004/diff/1/content/renderer/render_view...
File content/renderer/render_view_impl.h (right):

https://codereview.chromium.org/260623004/diff/1/content/renderer/render_view...
content/renderer/render_view_impl.h:837: void updateSmartClipDataResult(const
blink::WebString& text,
nit: put this in the right order (i.e. see where the other methods that
implement that WebViewClient interface are)

https://codereview.chromium.org/260623004/diff/1/content/renderer/render_view...
File content/renderer/render_view_impl_android.cc (right):

https://codereview.chromium.org/260623004/diff/1/content/renderer/render_view...
content/renderer/render_view_impl_android.cc:74: ViewHostMsg_SmartClip_Params
params;
we only create IPC structs when we have more than 5 input or 5 output
parameters, since that's what the IPC macros cover

[AviD, 2014-05-02 15:04:44]

Changes done as per review comments.

PTAL

https://codereview.chromium.org/260623004/diff/1/content/renderer/render_view...
File content/renderer/render_view_impl.h (right):

https://codereview.chromium.org/260623004/diff/1/content/renderer/render_view...
content/renderer/render_view_impl.h:837: void updateSmartClipDataResult(const
blink::WebString& text,
On 2014/04/30 16:05:47, jam wrote:
> nit: put this in the right order (i.e. see where the other methods that
> implement that WebViewClient interface are)

Removed this interface.

https://codereview.chromium.org/260623004/diff/1/content/renderer/render_view...
File content/renderer/render_view_impl_android.cc (right):

https://codereview.chromium.org/260623004/diff/1/content/renderer/render_view...
content/renderer/render_view_impl_android.cc:74: ViewHostMsg_SmartClip_Params
params;
On 2014/04/30 16:05:47, jam wrote:
> we only create IPC structs when we have more than 5 input or 5 output
> parameters, since that's what the IPC macros cover

Removed IPC struct.

[AviD, 2014-05-05 11:46:55]

Hi jam

Please take a look at this CL
Blink side changes have landed
https://codereview.chromium.org/259263003/

Thanks
Avinaash

[jam, 2014-05-05 15:07:32]

lgtm

https://codereview.chromium.org/260623004/diff/20001/content/common/view_mess...
File content/common/view_messages.h (right):

https://codereview.chromium.org/260623004/diff/20001/content/common/view_mess...
content/common/view_messages.h:1735: gfx::Rect /* Clip rect bounds */)
by convention, the comment for an IPC parameter matches the name of the
parameter in the dispatching method. i.e. result & rect based on
OnSmartClipDataExtracted

[jschuh, 2014-05-05 16:54:19]

ipc security lgtm (notes: converting a serialized string into its component
string and rect)

[eseidel, 2014-05-29 00:29:48]

It looks like you have your required reviews and this just needs a CQ?

[AviD, 2014-05-30 09:38:55]

On 2014/05/29 00:29:48, eseidel wrote:
> It looks like you have your required reviews and this just needs a CQ?

This patch is dependent on https://codereview.chromium.org/259263003

Once the blink side is landed, the CQ bit can be enabled.

[AviD, 2014-06-21 06:20:15]

The CQ bit was checked by avi.nitk@samsung.com

[commit-bot: I haz the power, 2014-06-21 06:21:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/avi.nitk@samsung.com/260623004/40001

[commit-bot: I haz the power, 2014-06-21 07:12:36]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/19953)

[commit-bot: I haz the power, 2014-06-21 07:14:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-21 07:14:25]

Try jobs failed on following builders:
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/19966)

[AviD, 2014-06-23 06:50:04]

The CQ bit was checked by avi.nitk@samsung.com

[commit-bot: I haz the power, 2014-06-23 06:51:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/avi.nitk@samsung.com/260623004/60001

[AviD, 2014-06-23 07:39:49]

The CQ bit was checked by avi.nitk@samsung.com

[commit-bot: I haz the power, 2014-06-23 07:40:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/avi.nitk@samsung.com/260623004/80001

[commit-bot: I haz the power, 2014-06-23 09:52:19]

Change committed as 279072