Add markdown instructions for using hermetic toolchain on mac and ios.

Add markdown instructions for using hermetic toolchain on mac and ios.

BUG=669094
Review-Url: https://codereview.chromium.org/2606223003
Cr-Commit-Position: refs/heads/master@{#446039}
Committed: https://chromium.googlesource.com/chromium/src/+/ae73b40100a1e6a84f862537be2500c242fa76f1

[justincohen, 2017-01-02 20:00:03]

Description was changed from

==========
Add markdown for using hermetic toolchain on mac and ios.

BUG=669094
==========

to

==========
Add markdown instructions for using hermetic toolchain on mac and ios.

BUG=669094
==========

[justincohen, 2017-01-02 20:00:12]

justincohen@chromium.org changed reviewers:
+ erikchen@chromium.org

[justincohen, 2017-01-02 20:00:12]

Since hermetic is only used by internal developers and the bots, any thoughts on
how detailed this should be?  I used some of your language in the mac hermetic
design doc here.

[erikchen, 2017-01-17 19:33:09]

lgtm

lgtm with nit

https://codereview.chromium.org/2606223003/diff/1/build/mac_hermetic_toolchai...
File build/mac_hermetic_toolchain.md (right):

https://codereview.chromium.org/2606223003/diff/1/build/mac_hermetic_toolchai...
build/mac_hermetic_toolchain.md:33: Chrome ships its own version of clang
[compiler], but is dependent on the system
> "depend on the system install of Xcode"
this is no longer true with hermetic.

IMO, there are two main benefits to hermetic toolchain:
1) Build Chrome with a well-defined toolchain [rather than whatever happens to
be installed on the machine].
2) Easily roll/update the toolchain.

[justincohen, 2017-01-17 21:59:07]

justincohen@chromium.org changed reviewers:
+ thakis@chromium.org

[justincohen, 2017-01-17 21:59:08]

Over to thakis@ for OWNERS

[justincohen, 2017-01-25 13:42:32]

thakis@ ping

[Nico, 2017-01-25 14:35:20]

lgtm

I note that almost all non-third_party .md files are in some "doc(s)" folder:

https://cs.chromium.org/search/?q=file:%5C.md$+-file:readme+-file:src/docs+-f...
https://cs.chromium.org/search/?q=file:%5C.md$+-file:readme+-file:src/docs+-f...

[justincohen, 2017-01-25 16:40:29]

Good point, moved into build/docs/

thanks for the review!

[justincohen, 2017-01-25 16:40:35]

The CQ bit was checked by justincohen@chromium.org

[justincohen, 2017-01-25 16:40:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikchen@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2606223003/#ps40001
(title: "Moved into docs dir")

[commit-bot: I haz the power, 2017-01-25 16:41:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 16:56:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485362435562770,
"parent_rev": "81c970230a492e70e9a580c38e4de8a3f0fcc29b", "commit_rev":
"ae73b40100a1e6a84f862537be2500c242fa76f1"}

[commit-bot: I haz the power, 2017-01-25 16:57:20]

Description was changed from

==========
Add markdown instructions for using hermetic toolchain on mac and ios.

BUG=669094
==========

to

==========
Add markdown instructions for using hermetic toolchain on mac and ios.

BUG=669094

Review-Url: https://codereview.chromium.org/2606223003
Cr-Commit-Position: refs/heads/master@{#446039}
Committed:
https://chromium.googlesource.com/chromium/src/+/ae73b40100a1e6a84f862537be25...
==========

[commit-bot: I haz the power, 2017-01-25 16:57:21]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ae73b40100a1e6a84f862537be25...