|
|
Chromium Code Reviews
DescriptionRemove usage of WorkerPool from test_completion_callback_unittest.cc.
WorkerPool is being deprecated.
BUG=659191
Committed: https://crrev.com/5e2b890a2d2663595aa141e3f70c1af94d46c897
Cr-Commit-Position: refs/heads/master@{#441198}
Patch Set 1 #Patch Set 2 : fix build error #Messages
Total messages: 19 (14 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Use TaskScheduler instead of WorkerPool in test_completion_callback_unittest.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. Does Not Block (default): Tasks without the MayBlock() and WithBaseSyncPrimitives() traits may not block. BUG=659191 ========== to ========== Remove usage of WorkerPool from test_completion_callback_unittest.cc. WorkerPool is being deprecated. BUG=659191 ==========
fdoray@chromium.org changed reviewers: + asanka@chromium.org
PTAL
lgtm
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483472373300100,
"parent_rev": "e32f51c6aeefe5b2f4f2e8efaf2f969ca202de7d", "commit_rev":
"05ac807e19b2bc588a36d8d69b81f6d9a0087ffd"}
Message was sent while issue was closed.
Description was changed from ========== Remove usage of WorkerPool from test_completion_callback_unittest.cc. WorkerPool is being deprecated. BUG=659191 ========== to ========== Remove usage of WorkerPool from test_completion_callback_unittest.cc. WorkerPool is being deprecated. BUG=659191 Review-Url: https://codereview.chromium.org/2606213003 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove usage of WorkerPool from test_completion_callback_unittest.cc. WorkerPool is being deprecated. BUG=659191 Review-Url: https://codereview.chromium.org/2606213003 ========== to ========== Remove usage of WorkerPool from test_completion_callback_unittest.cc. WorkerPool is being deprecated. BUG=659191 Committed: https://crrev.com/5e2b890a2d2663595aa141e3f70c1af94d46c897 Cr-Commit-Position: refs/heads/master@{#441198} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5e2b890a2d2663595aa141e3f70c1af94d46c897 Cr-Commit-Position: refs/heads/master@{#441198} |
