Issue 2606143002: Fix RGBA alpha parsing and serialization to adhere to W3 standard.

ktyliu_google

The CQ bit was checked by ktyliu@google.com to run a CQ dry run

3 years, 11 months ago (2016-12-30 05:14:16 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606143002/1

3 years, 11 months ago (2016-12-30 05:14:27 UTC) #2

ktyliu

Description was changed from ========== Fix RGBA alpha parsing and serialization to adhere to W3 ...

3 years, 11 months ago (2016-12-30 05:24:56 UTC) #3

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 11 months ago (2016-12-30 06:35:04 UTC) #4

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/363342)

3 years, 11 months ago (2016-12-30 06:35:05 UTC) #5

ktyliu_google

The CQ bit was checked by ktyliu@google.com to run a CQ dry run

3 years, 11 months ago (2017-01-02 22:29:05 UTC) #6

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606143002/20001

3 years, 11 months ago (2017-01-02 22:29:08 UTC) #7

ktyliu

ktyliu@chromium.org changed reviewers: + sashab@chromium.org

3 years, 11 months ago (2017-01-02 22:46:40 UTC) #8

ktyliu

ktyliu@chromium.org changed reviewers: + ktyliu@chromium.org

3 years, 11 months ago (2017-01-02 22:48:07 UTC) #9

ktyliu

Hi Sasha, Good to see you again after the break! Please help review my very ...

3 years, 11 months ago (2017-01-02 22:48:07 UTC) #10

sashab

Thanks for the patch -- not sure what a lot of it does, maybe you ...

3 years, 11 months ago (2017-01-02 23:04:16 UTC) #11

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 11 months ago (2017-01-02 23:40:36 UTC) #12

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/356742)

3 years, 11 months ago (2017-01-02 23:40:37 UTC) #13

sashab

Example of clampTo<> usage, and a testharness.js test without -expectations file -- https://codereview.chromium.org/2597103002/

3 years, 11 months ago (2017-01-02 23:43:45 UTC) #14

ktyliu

Description was changed from ========== Fix RGBA alpha parsing and serialization to adhere to W3 ...

3 years, 11 months ago (2017-01-03 01:53:02 UTC) #15

ktyliu

Thanks for the detailed review and suggestions! However, I found that several layout tests seem ...

3 years, 11 months ago (2017-01-03 02:11:25 UTC) #16

ktyliu

https://codereview.chromium.org/2606143002/diff/20001/third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value-expected.txt File third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value-expected.txt (right): https://codereview.chromium.org/2606143002/diff/20001/third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value-expected.txt#newcode1 third_party/WebKit/LayoutTests/css-parser/serialize-css-alpha-value-expected.txt:1: This tests if floating point alpha values of numbers ...

3 years, 11 months ago (2017-01-03 02:14:22 UTC) #17

sashab

3 years, 11 months ago (2017-01-03 02:14:39 UTC) #18

Sure.

I would also be happy to split this into two patches - one to update the layout
tests, and the other to add your fix.

ktyliu

3 years, 11 months ago (2017-01-03 04:01:11 UTC) #19

Description was changed from

==========
Fix RGBA alpha parsing and serialization to adhere to W3 standard.

Specifically, a 2.55 multiplication factor should be used, and
serialization should be to two or three digits according to section
<alphavalue> in https://drafts.csswg.org/cssom/#serializing-css-values

This fixes test case "background-color: rgba(5, 7, 10, 0.5)" in
https://w3c-test.org/cssom/serialize-values.html

BUG=453414
==========

to

==========
Fix RGBA alpha parsing and serialization to adhere to W3 standard.

Specifically, a 2.55 multiplication factor should be used, and
serialization should be to two or three digits according to section
<alphavalue> in https://drafts.csswg.org/cssom/#serializing-css-values

This fixes test case "background-color: rgba(5, 7, 10, 0.5)" in
https://w3c-test.org/cssom/serialize-values.html

Note a large number of tests need to be fixed, many of them are because
an alpha value of 0.5 was previously 127 but should have been 128.

BUG=453414
==========

Issue 2606143002: Fix RGBA alpha parsing and serialization to adhere to W3 standard. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix blending #

Patch Set 3 : fixes to address reviewer comments #

Messages