Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2606143002: Fix RGBA alpha parsing and serialization to adhere to W3 standard. (Closed)
Patch Set: fixes to address reviewer comments Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/Color.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
index 0840d8c1b77fabff9833895c78e37f803c92c267..4bb2739ec73b879b1c68b087f7de6cbd5437d727 100644
--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
@@ -394,11 +394,11 @@ TEST_P(WebViewTest, SetBaseBackgroundColor) {
"style></head></html>",
baseURL);
// Expected: red (50% alpha) blended atop base of kBlue.
- EXPECT_EQ(0xFF7F0080, webView->backgroundColor());
+ EXPECT_EQ(0xFF80007F, webView->backgroundColor());
webView->setBaseBackgroundColor(kTranslucentPutty);
// Expected: red (50% alpha) blended atop kTranslucentPutty. Note the alpha.
- EXPECT_EQ(0xBFE93B32, webView->backgroundColor());
+ EXPECT_EQ(0xBFE93A31, webView->backgroundColor());
webView->setBaseBackgroundColor(kTransparent);
FrameTestHelpers::loadHTMLString(webView->mainFrame(),
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/Color.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698