Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2606063003: CSS Transitions: Correct expectation for position-background-transition (Closed)

Created:
3 years, 11 months ago by Eric Willigers
Modified:
3 years, 11 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS Transitions: Correct expectation for position-background-transition The test's final styles, including transform, are used as the expectation styles. BUG=664859 Committed: https://crrev.com/2d78d74961f1cdb4a442a7070274bf9ae0c234c9 Cr-Commit-Position: refs/heads/master@{#441089}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/transitions/position-background-transition.html View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/transitions/position-background-transition-expected.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
Eric Willigers
3 years, 11 months ago (2016-12-30 00:31:23 UTC) #4
alancutter (OOO until 2018)
lgtm
3 years, 11 months ago (2017-01-03 02:01:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606063003/20001
3 years, 11 months ago (2017-01-03 04:51:00 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-03 04:55:08 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 04:57:33 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d78d74961f1cdb4a442a7070274bf9ae0c234c9
Cr-Commit-Position: refs/heads/master@{#441089}

Powered by Google App Engine
This is Rietveld 408576698